Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2113453007:
[Android] Switch outdated pylib.* references to equivalent devil.android.* ones. (Closed)
|
Created:
4 years, 5 months ago by jbudorick Modified:
4 years, 5 months ago Reviewers:
Michael Achenbach CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[Android] Switch outdated pylib.* references to equivalent devil.android.* ones.
BUG=chromium:617761
NOTRY=true
Committed: https://crrev.com/f2ce4fe63ba80fdcf3ca2dc078e9a78d1da0f9e5
Cr-Commit-Position: refs/heads/master@{#37616}
Patch Set 1 #
Total comments: 2
Messages
Total messages: 16 (7 generated)
jbudorick@chromium.org changed reviewers: + machenbach@chromium.org
lgtm if this works with the old path. Otherwise we need to also update the buildbot side. https://codereview.chromium.org/2113453007/diff/1/tools/run_perf.py File tools/run_perf.py (right): https://codereview.chromium.org/2113453007/diff/1/tools/run_perf.py#newcode127 tools/run_perf.py:127: def LoadAndroidBuildTools(path): # pragma: no cover Does the path now need to point to src/third_party/catapult/devil? Right now it points to src/build/android.
https://codereview.chromium.org/2113453007/diff/1/tools/run_perf.py File tools/run_perf.py (right): https://codereview.chromium.org/2113453007/diff/1/tools/run_perf.py#newcode127 tools/run_perf.py:127: def LoadAndroidBuildTools(path): # pragma: no cover On 2016/07/05 10:16:39, Michael Achenbach wrote: > Does the path now need to point to src/third_party/catapult/devil? Right now it > points to src/build/android. devil_chromium takes care of that part. I could change it to point to third_party/catapult/devil, but it isn't strictly necessary for this CL and involves broader changes AFAICT.
lgtm
The CQ bit was checked by jbudorick@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/8735) v8_linux64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng_triggered...)
Description was changed from ========== [Android] Switch outdated pylib.* references to equivalent devil.android.* ones. BUG=chromium:617761 ========== to ========== [Android] Switch outdated pylib.* references to equivalent devil.android.* ones. BUG=chromium:617761 NOTRY=true ==========
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Android] Switch outdated pylib.* references to equivalent devil.android.* ones. BUG=chromium:617761 NOTRY=true ========== to ========== [Android] Switch outdated pylib.* references to equivalent devil.android.* ones. BUG=chromium:617761 NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [Android] Switch outdated pylib.* references to equivalent devil.android.* ones. BUG=chromium:617761 NOTRY=true ========== to ========== [Android] Switch outdated pylib.* references to equivalent devil.android.* ones. BUG=chromium:617761 NOTRY=true Committed: https://crrev.com/f2ce4fe63ba80fdcf3ca2dc078e9a78d1da0f9e5 Cr-Commit-Position: refs/heads/master@{#37616} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/f2ce4fe63ba80fdcf3ca2dc078e9a78d1da0f9e5 Cr-Commit-Position: refs/heads/master@{#37616} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
