Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2113453002: [Autofill] Structure AutofillField tests a little better (Closed)

Created:
4 years, 5 months ago by Mathieu
Modified:
4 years, 5 months ago
Reviewers:
sebsg
CC:
chromium-reviews, rouslan+autofill_chromium.org, estade+watch_chromium.org, vabr+watchlistautofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autofill] Structure AutofillField tests a little better Refactored using Seb's method ;) BUG=None TEST=AutofillFieldTest Committed: https://crrev.com/f6695626c8b40f3a40977cb91017698c7eafb783 Cr-Commit-Position: refs/heads/master@{#403162}

Patch Set 1 #

Patch Set 2 : Quebec #

Total comments: 2

Patch Set 3 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -118 lines) Patch
M components/autofill/core/browser/autofill_field_unittest.cc View 1 2 1 chunk +53 lines, -118 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Mathieu
Hi Seb, PTAL
4 years, 5 months ago (2016-06-29 21:35:32 UTC) #2
sebsg
LGTM with a small comment. Thanks! Refactor all the tests! https://codereview.chromium.org/2113453002/diff/20001/components/autofill/core/browser/autofill_field_unittest.cc File components/autofill/core/browser/autofill_field_unittest.cc (right): https://codereview.chromium.org/2113453002/diff/20001/components/autofill/core/browser/autofill_field_unittest.cc#newcode437 ...
4 years, 5 months ago (2016-06-30 09:48:16 UTC) #3
Mathieu
Thanks will submit https://codereview.chromium.org/2113453002/diff/20001/components/autofill/core/browser/autofill_field_unittest.cc File components/autofill/core/browser/autofill_field_unittest.cc (right): https://codereview.chromium.org/2113453002/diff/20001/components/autofill/core/browser/autofill_field_unittest.cc#newcode437 components/autofill/core/browser/autofill_field_unittest.cc:437: // Do accidentally match "Virginia" to ...
4 years, 5 months ago (2016-06-30 12:21:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2113453002/40001
4 years, 5 months ago (2016-06-30 12:22:33 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-30 13:23:55 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 13:26:44 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/f6695626c8b40f3a40977cb91017698c7eafb783
Cr-Commit-Position: refs/heads/master@{#403162}

Powered by Google App Engine
This is Rietveld 408576698