Reland: Remove unsafe cast from ImageTransportSurfaceOverlayMac::ScheduleCALayer.

Reland: Remove unsafe cast from ImageTransportSurfaceOverlayMac::ScheduleCALayer.

Create an enum class Type in GLImage, which allows for safe downcasting.

BUG=619698, 624256
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/ab056ef99dba995671df54dc97d738161cdc2188
Cr-Commit-Position: refs/heads/master@{#403091}

[piman, 2016-06-30 03:30:29]

Description was changed from

==========
Reland: Remove unsafe cast from
ImageTransportSurfaceOverlayMac::ScheduleCALayer.

Create an enum class Type in GLImage, which allows for safe downcasting.

BUG=619698,624256
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Reland: Remove unsafe cast from
ImageTransportSurfaceOverlayMac::ScheduleCALayer.

Create an enum class Type in GLImage, which allows for safe downcasting.

BUG=619698,624256
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[piman, 2016-06-30 03:31:39]

piman@chromium.org changed reviewers:
+ ccameron@chromium.org

[piman, 2016-06-30 03:31:39]

ccameron: PTAL. PS1 is the original patch that was reverted, PS2 has the fix.

[ccameron, 2016-06-30 03:57:55]

lgtm with the error

https://codereview.chromium.org/2113443003/diff/20001/gpu/ipc/service/image_t...
File gpu/ipc/service/image_transport_surface_overlay_mac.mm (right):

https://codereview.chromium.org/2113443003/diff/20001/gpu/ipc/service/image_t...
gpu/ipc/service/image_transport_surface_overlay_mac.mm:349: if
(io_surface_image) {
We should have an error message, for instance:

if (contents_image) {
  gl::GLImageIOSurface* io_surface_image =
    gl::GLImageIOSurface::FromGLImage(contents_image);
  if (!io_surface_image) {
    DLOG(ERROR) << "Cannot schedule CALayer with non-IOSurface GLImage";
    return false
  }
  io_surface = io_surface_image->io_surface();
  cv_pixel_buffer = io_surface_image->cv_pixel_buffer();
}

[piman, 2016-06-30 04:03:18]

https://codereview.chromium.org/2113443003/diff/20001/gpu/ipc/service/image_t...
File gpu/ipc/service/image_transport_surface_overlay_mac.mm (right):

https://codereview.chromium.org/2113443003/diff/20001/gpu/ipc/service/image_t...
gpu/ipc/service/image_transport_surface_overlay_mac.mm:349: if
(io_surface_image) {
On 2016/06/30 03:57:55, ccameron wrote:
> We should have an error message, for instance:
> 
> if (contents_image) {
>   gl::GLImageIOSurface* io_surface_image =
>     gl::GLImageIOSurface::FromGLImage(contents_image);
>   if (!io_surface_image) {
>     DLOG(ERROR) << "Cannot schedule CALayer with non-IOSurface GLImage";
>     return false
>   }
>   io_surface = io_surface_image->io_surface();
>   cv_pixel_buffer = io_surface_image->cv_pixel_buffer();
> }

Done.

[piman, 2016-06-30 04:03:26]

The CQ bit was checked by piman@chromium.org

[piman, 2016-06-30 04:03:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
ccameron@chromium.org
Link to the patchset: https://codereview.chromium.org/2113443003/#ps40001
(title: "Add error message in ImageTransportSurfaceOverlayMac::ScheduleCALayer")

[commit-bot: I haz the power, 2016-06-30 04:03:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 05:16:12]

Description was changed from

==========
Reland: Remove unsafe cast from
ImageTransportSurfaceOverlayMac::ScheduleCALayer.

Create an enum class Type in GLImage, which allows for safe downcasting.

BUG=619698,624256
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Reland: Remove unsafe cast from
ImageTransportSurfaceOverlayMac::ScheduleCALayer.

Create an enum class Type in GLImage, which allows for safe downcasting.

BUG=619698,624256
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-06-30 05:16:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-30 05:16:14]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-30 05:17:54]

Description was changed from

==========
Reland: Remove unsafe cast from
ImageTransportSurfaceOverlayMac::ScheduleCALayer.

Create an enum class Type in GLImage, which allows for safe downcasting.

BUG=619698,624256
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Reland: Remove unsafe cast from
ImageTransportSurfaceOverlayMac::ScheduleCALayer.

Create an enum class Type in GLImage, which allows for safe downcasting.

BUG=619698,624256
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/ab056ef99dba995671df54dc97d738161cdc2188
Cr-Commit-Position: refs/heads/master@{#403091}
==========

[commit-bot: I haz the power, 2016-06-30 05:17:55]

Patchset 3 (id:??) landed as
https://crrev.com/ab056ef99dba995671df54dc97d738161cdc2188
Cr-Commit-Position: refs/heads/master@{#403091}

[erikchen, 2016-07-04 15:38:56]

erikchen@chromium.org changed reviewers:
+ erikchen@chromium.org

[erikchen, 2016-07-04 15:38:57]

lgtm