Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2113443002:
add SK_SUPPORT_PRECHECK_CLIPRECT experiment for clipRect (Closed)
Descriptionadd SK_SUPPORT_PRECHECK_CLIPRECT experiment for clipRect
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2113443002
Committed: https://skia.googlesource.com/skia/+/2d1afab8ef2db8b4f0bdab387b0e42ccee1db64f
Patch Set 1 #
Total comments: 6
Patch Set 2 #Messages
Total messages: 16 (8 generated)
Description was changed from ========== add SK_SUPPORT_PRECHECK_CLIPRECT experiment for clipRect BUG=skia: ========== to ========== add SK_SUPPORT_PRECHECK_CLIPRECT experiment for clipRect BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2113443002 ==========
reed@google.com changed reviewers: + fmalita@chromium.org
android will enable locally to test
The CQ bit was checked by reed@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM https://codereview.chromium.org/2113443002/diff/1/src/core/SkCanvas.cpp File src/core/SkCanvas.cpp (right): https://codereview.chromium.org/2113443002/diff/1/src/core/SkCanvas.cpp#newco... src/core/SkCanvas.cpp:1535: fMCRec->fMatrix.mapRect(&devR, rect); Can we move all this under the top-level conditional below? https://codereview.chromium.org/2113443002/diff/1/src/core/SkCanvas.cpp#newco... src/core/SkCanvas.cpp:1540: // TODO: investigate if a (conservative) version of this could be done in ::clipRect, Nit: TODO solved :) https://codereview.chromium.org/2113443002/diff/1/src/core/SkCanvas.cpp#newco... src/core/SkCanvas.cpp:1545: if (devR.round().contains(fMCRec->fRasterClip.getBounds())) { Maybe add a comment about round() vs. unknown resolution caveat.
reed@google.com changed reviewers: + liyuqian@google.com, mtklein@google.com
android would need to locally uncomment the flag at the top of the file
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2113443002/diff/1/src/core/SkCanvas.cpp File src/core/SkCanvas.cpp (right): https://codereview.chromium.org/2113443002/diff/1/src/core/SkCanvas.cpp#newco... src/core/SkCanvas.cpp:1535: fMCRec->fMatrix.mapRect(&devR, rect); On 2016/06/29 20:55:52, f(malita) wrote: > Can we move all this under the top-level conditional below? Done. https://codereview.chromium.org/2113443002/diff/1/src/core/SkCanvas.cpp#newco... src/core/SkCanvas.cpp:1540: // TODO: investigate if a (conservative) version of this could be done in ::clipRect, On 2016/06/29 20:55:52, f(malita) wrote: > Nit: TODO solved :) Done. https://codereview.chromium.org/2113443002/diff/1/src/core/SkCanvas.cpp#newco... src/core/SkCanvas.cpp:1545: if (devR.round().contains(fMCRec->fRasterClip.getBounds())) { On 2016/06/29 20:55:52, f(malita) wrote: > Maybe add a comment about round() vs. unknown resolution caveat. Done.
The CQ bit was checked by reed@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from fmalita@chromium.org Link to the patchset: https://codereview.chromium.org/2113443002/#ps20001 (title: "")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== add SK_SUPPORT_PRECHECK_CLIPRECT experiment for clipRect BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2113443002 ========== to ========== add SK_SUPPORT_PRECHECK_CLIPRECT experiment for clipRect BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2113443002 Committed: https://skia.googlesource.com/skia/+/2d1afab8ef2db8b4f0bdab387b0e42ccee1db64f ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/2d1afab8ef2db8b4f0bdab387b0e42ccee1db64f |
