Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2113433002: Comment out frequently flaky PrivateStore test (Closed)

Created:
4 years, 5 months ago by Pete Williamson
Modified:
4 years, 5 months ago
Reviewers:
afakhry, xiyuan
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, Peng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Comment out frequently flaky PrivateStore test This has been failing a lot on the waterfall, commenting it out until it can be investigated and re-enabled BUG=624201 TBR=dzhioev Committed: https://crrev.com/d056e7e6f2591527523c92b429d70b5df3c3114f Cr-Commit-Position: refs/heads/master@{#402903}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/browser/chromeos/login/kiosk_browsertest.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
Pete Williamson
4 years, 5 months ago (2016-06-29 18:41:18 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2113433002/1
4 years, 5 months ago (2016-06-29 18:45:54 UTC) #5
afakhry
+xiyuan. lgtm.
4 years, 5 months ago (2016-06-29 18:47:24 UTC) #7
xiyuan
lgtm
4 years, 5 months ago (2016-06-29 19:02:01 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-29 19:29:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2113433002/1
4 years, 5 months ago (2016-06-29 19:30:55 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 19:41:50 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-29 19:42:01 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 19:44:00 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d056e7e6f2591527523c92b429d70b5df3c3114f
Cr-Commit-Position: refs/heads/master@{#402903}

Powered by Google App Engine
This is Rietveld 408576698