Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2113413002:
[Android] Guard android_assets usage with enable_java_templates. (Closed)
|
Created:
4 years, 5 months ago by jbudorick Modified:
4 years, 5 months ago Reviewers:
Michael Achenbach CC:
v8-reviews_googlegroups.com, agrieve Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[Android] Guard android_assets usage with enable_java_templates.
BUG=pdfium:38
Committed: https://crrev.com/4ff581dd3a15e4462ceae9c8bd5b254438f01e20
Cr-Commit-Position: refs/heads/master@{#37592}
Patch Set 1 #Patch Set 2 : rebase #Messages
Total messages: 14 (4 generated)
jbudorick@chromium.org changed reviewers: + machenbach@chromium.org
lgtm
The CQ bit was checked by jbudorick@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from machenbach@chromium.org Link to the patchset: https://codereview.chromium.org/2113413002/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== [Android] Guard android_assets usage with enable_java_templates. BUG=pdfium:38 ========== to ========== [Android] Guard android_assets usage with enable_java_templates. BUG=pdfium:38 Committed: https://crrev.com/4ff581dd3a15e4462ceae9c8bd5b254438f01e20 Cr-Commit-Position: refs/heads/master@{#37592} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/4ff581dd3a15e4462ceae9c8bd5b254438f01e20 Cr-Commit-Position: refs/heads/master@{#37592}
Message was sent while issue was closed.
Maybe I stamped this a bit too fast. Could you explain why we need this and how we'd support it in v8 standalone? It looks like the required gni files are hard-checked-in into chromium and not deps'ed in. Like that, our android build with gn would fail: https://build.chromium.org/p/client.v8.ports/builders/V8%20Android%20Arm%20-%... Can we continue without ijar? Or do we need to add a subtreed for ijar and deps?
Message was sent while issue was closed.
On 2016/07/25 15:40:09, Michael Achenbach (slow) wrote: > Maybe I stamped this a bit too fast. Could you explain why we need this and how > we'd support it in v8 standalone? > > It looks like the required gni files are hard-checked-in into chromium and not > deps'ed in. > > Like that, our android build with gn would fail: > https://build.chromium.org/p/client.v8.ports/builders/V8%20Android%20Arm%20-%... > > Can we continue without ijar? Or do we need to add a subtreed for ijar and deps? I don't think this patch is responsible for that bot failing; this merely put an additional flag guarding the use of the android_assets template. //BUILD.gn was already pulling in //build/config/android/rules.gni.
Message was sent while issue was closed.
On 2016/07/25 15:43:58, jbudorick wrote: > On 2016/07/25 15:40:09, Michael Achenbach (slow) wrote: > > Maybe I stamped this a bit too fast. Could you explain why we need this and > how > > we'd support it in v8 standalone? > > > > It looks like the required gni files are hard-checked-in into chromium and not > > deps'ed in. > > > > Like that, our android build with gn would fail: > > > https://build.chromium.org/p/client.v8.ports/builders/V8%20Android%20Arm%20-%... > > > > Can we continue without ijar? Or do we need to add a subtreed for ijar and > deps? > > I don't think this patch is responsible for that bot failing; this merely put an > additional flag guarding the use of the android_assets template. //BUILD.gn was > already pulling in //build/config/android/rules.gni. Right, so what I wanted to ask, can I set enable_java_templates to false, just like pdfium does and still build v8 standalone for android?
Message was sent while issue was closed.
On 2016/07/25 15:45:41, Michael Achenbach (slow) wrote: > On 2016/07/25 15:43:58, jbudorick wrote: > > On 2016/07/25 15:40:09, Michael Achenbach (slow) wrote: > > > Maybe I stamped this a bit too fast. Could you explain why we need this and > > how > > > we'd support it in v8 standalone? > > > > > > It looks like the required gni files are hard-checked-in into chromium and > not > > > deps'ed in. > > > > > > Like that, our android build with gn would fail: > > > > > > https://build.chromium.org/p/client.v8.ports/builders/V8%20Android%20Arm%20-%... > > > > > > Can we continue without ijar? Or do we need to add a subtreed for ijar and > > deps? > > > > I don't think this patch is responsible for that bot failing; this merely put > an > > additional flag guarding the use of the android_assets template. //BUILD.gn > was > > already pulling in //build/config/android/rules.gni. > > Right, so what I wanted to ask, can I set enable_java_templates to false, just > like pdfium does and still build v8 standalone for android? Oh, sorry, I misunderstood you. If v8 doesn't build any java targets, then yes, it should work. (I only see java files in //test/mozilla/data and //build/android; I'm guessing you don't build the latter but am not sure about the former.) |
