Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2308)

Unified Diff: components/offline_pages/background/request_queue_store_unittest.cc

Issue 2113383002: More detailed implementation of the RequestPicker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix time check and MeetsConditions check Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_queue_store_unittest.cc
diff --git a/components/offline_pages/background/request_queue_store_unittest.cc b/components/offline_pages/background/request_queue_store_unittest.cc
index 32c6ab649fd4df6c7335d12614b8305a7425cc09..7a75be9d265f4bf3db0c0a934551bcc8d0265ba4 100644
--- a/components/offline_pages/background/request_queue_store_unittest.cc
+++ b/components/offline_pages/background/request_queue_store_unittest.cc
@@ -24,6 +24,7 @@ namespace {
const int64_t kRequestId = 42;
const GURL kUrl("http://example.com");
const ClientId kClientId("bookmark", "1234");
+const bool kUserRequested = true;
enum class LastResult {
kNone,
@@ -195,7 +196,8 @@ TYPED_TEST(RequestQueueStoreTest, GetRequestsEmpty) {
TYPED_TEST(RequestQueueStoreTest, AddRequest) {
std::unique_ptr<RequestQueueStore> store(this->BuildStore());
base::Time creation_time = base::Time::Now();
- SavePageRequest request(kRequestId, kUrl, kClientId, creation_time);
+ SavePageRequest request(
+ kRequestId, kUrl, kClientId, creation_time, kUserRequested);
store->AddOrUpdateRequest(
request, base::Bind(&RequestQueueStoreTestBase::AddOrUpdateDone,
@@ -218,7 +220,8 @@ TYPED_TEST(RequestQueueStoreTest, AddRequest) {
TYPED_TEST(RequestQueueStoreTest, UpdateRequest) {
std::unique_ptr<RequestQueueStore> store(this->BuildStore());
base::Time creation_time = base::Time::Now();
- SavePageRequest original_request(kRequestId, kUrl, kClientId, creation_time);
+ SavePageRequest original_request(
+ kRequestId, kUrl, kClientId, creation_time, kUserRequested);
store->AddOrUpdateRequest(
original_request, base::Bind(&RequestQueueStoreTestBase::AddOrUpdateDone,
base::Unretained(this)));
@@ -229,7 +232,8 @@ TYPED_TEST(RequestQueueStoreTest, UpdateRequest) {
creation_time + base::TimeDelta::FromMinutes(1);
base::Time activation_time = creation_time + base::TimeDelta::FromHours(6);
SavePageRequest updated_request(kRequestId, kUrl, kClientId,
- new_creation_time, activation_time);
+ new_creation_time, activation_time,
+ kUserRequested);
store->AddOrUpdateRequest(
updated_request, base::Bind(&RequestQueueStoreTestBase::AddOrUpdateDone,
base::Unretained(this)));
@@ -251,7 +255,8 @@ TYPED_TEST(RequestQueueStoreTest, UpdateRequest) {
TYPED_TEST(RequestQueueStoreTest, RemoveRequest) {
std::unique_ptr<RequestQueueStore> store(this->BuildStore());
base::Time creation_time = base::Time::Now();
- SavePageRequest original_request(kRequestId, kUrl, kClientId, creation_time);
+ SavePageRequest original_request(
+ kRequestId, kUrl, kClientId, creation_time, kUserRequested);
store->AddOrUpdateRequest(
original_request, base::Bind(&RequestQueueStoreTestBase::AddOrUpdateDone,
base::Unretained(this)));
@@ -290,7 +295,8 @@ TYPED_TEST(RequestQueueStoreTest, RemoveRequest) {
TYPED_TEST(RequestQueueStoreTest, ResetStore) {
std::unique_ptr<RequestQueueStore> store(this->BuildStore());
base::Time creation_time = base::Time::Now();
- SavePageRequest original_request(kRequestId, kUrl, kClientId, creation_time);
+ SavePageRequest original_request(
+ kRequestId, kUrl, kClientId, creation_time, kUserRequested);
store->AddOrUpdateRequest(
original_request, base::Bind(&RequestQueueStoreTestBase::AddOrUpdateDone,
base::Unretained(this)));
@@ -319,7 +325,8 @@ class RequestQueueStoreSQLTest
TEST_F(RequestQueueStoreSQLTest, SaveCloseReopenRead) {
std::unique_ptr<RequestQueueStore> store(BuildStore());
base::Time creation_time = base::Time::Now();
- SavePageRequest original_request(kRequestId, kUrl, kClientId, creation_time);
+ SavePageRequest original_request(
+ kRequestId, kUrl, kClientId, creation_time, kUserRequested);
store->AddOrUpdateRequest(
original_request, base::Bind(&RequestQueueStoreTestBase::AddOrUpdateDone,
base::Unretained(this)));

Powered by Google App Engine
This is Rietveld 408576698