Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: components/offline_pages/background/request_queue_unittest.cc

Issue 2113383002: More detailed implementation of the RequestPicker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix merge Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_queue_unittest.cc
diff --git a/components/offline_pages/background/request_queue_unittest.cc b/components/offline_pages/background/request_queue_unittest.cc
index 85628d1ee551fd99d2fb78dfa43ed1d8b4bafb57..80f776b9074ebf14502ce221e305cd484a89e355 100644
--- a/components/offline_pages/background/request_queue_unittest.cc
+++ b/components/offline_pages/background/request_queue_unittest.cc
@@ -28,6 +28,7 @@ const ClientId kClientId("bookmark", "1234");
const int64_t kRequestId2 = 77;
const GURL kUrl2("http://test.com");
const ClientId kClientId2("bookmark", "567");
+const bool kUserRequested = true;
} // namespace
// TODO(fgorski): Add tests for store failures in add/remove/get.
@@ -125,7 +126,8 @@ TEST_F(RequestQueueTest, GetRequestsEmpty) {
TEST_F(RequestQueueTest, AddRequest) {
base::Time creation_time = base::Time::Now();
- SavePageRequest request(kRequestId, kUrl, kClientId, creation_time);
+ SavePageRequest request(
+ kRequestId, kUrl, kClientId, creation_time, kUserRequested);
queue()->AddRequest(request, base::Bind(&RequestQueueTest::AddRequestDone,
base::Unretained(this)));
PumpLoop();
@@ -142,7 +144,8 @@ TEST_F(RequestQueueTest, AddRequest) {
TEST_F(RequestQueueTest, RemoveRequest) {
base::Time creation_time = base::Time::Now();
- SavePageRequest request(kRequestId, kUrl, kClientId, creation_time);
+ SavePageRequest request(
+ kRequestId, kUrl, kClientId, creation_time, kUserRequested);
queue()->AddRequest(request, base::Bind(&RequestQueueTest::AddRequestDone,
base::Unretained(this)));
PumpLoop();
@@ -165,12 +168,14 @@ TEST_F(RequestQueueTest, RemoveRequest) {
// listing multiple items and removing the right item.
TEST_F(RequestQueueTest, MultipleRequestsAddGetRemove) {
base::Time creation_time = base::Time::Now();
- SavePageRequest request1(kRequestId, kUrl, kClientId, creation_time);
+ SavePageRequest request1(
+ kRequestId, kUrl, kClientId, creation_time, kUserRequested);
queue()->AddRequest(request1, base::Bind(&RequestQueueTest::AddRequestDone,
base::Unretained(this)));
PumpLoop();
ASSERT_EQ(request1.request_id(), last_added_request()->request_id());
- SavePageRequest request2(kRequestId2, kUrl2, kClientId2, creation_time);
+ SavePageRequest request2(
+ kRequestId2, kUrl2, kClientId2, creation_time, kUserRequested);
queue()->AddRequest(request2, base::Bind(&RequestQueueTest::AddRequestDone,
base::Unretained(this)));
PumpLoop();

Powered by Google App Engine
This is Rietveld 408576698