Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1780)

Unified Diff: components/offline_pages/background/save_page_request_unittest.cc

Issue 2113383002: More detailed implementation of the RequestPicker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Simplify picker logic for multiple criteria Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/save_page_request_unittest.cc
diff --git a/components/offline_pages/background/save_page_request_unittest.cc b/components/offline_pages/background/save_page_request_unittest.cc
index bec07f295d6a2e8e35c1a2b92d0675636cf004fb..63b970f2e0fa09268472f0aa855ef242effb7118 100644
--- a/components/offline_pages/background/save_page_request_unittest.cc
+++ b/components/offline_pages/background/save_page_request_unittest.cc
@@ -12,6 +12,7 @@ namespace {
const int64_t kRequestId = 42;
const GURL kUrl("http://example.com");
const ClientId kClientId("bookmark", "1234");
+const bool kUserRequested = true;
} // namespace
class SavePageRequestTest : public testing::Test {
@@ -23,7 +24,8 @@ SavePageRequestTest::~SavePageRequestTest() {}
TEST_F(SavePageRequestTest, CreatePendingReqeust) {
base::Time creation_time = base::Time::Now();
- SavePageRequest request(kRequestId, kUrl, kClientId, creation_time);
+ SavePageRequest request(
+ kRequestId, kUrl, kClientId, creation_time, kUserRequested);
ASSERT_EQ(kRequestId, request.request_id());
ASSERT_EQ(kUrl, request.url());
ASSERT_EQ(kClientId, request.client_id());
@@ -41,7 +43,7 @@ TEST_F(SavePageRequestTest, CreateNotReadyRequest) {
base::Time creation_time = base::Time::Now();
base::Time activation_time = creation_time + base::TimeDelta::FromHours(6);
SavePageRequest request(kRequestId, kUrl, kClientId, creation_time,
- activation_time);
+ activation_time, kUserRequested);
ASSERT_EQ(kRequestId, request.request_id());
ASSERT_EQ(kUrl, request.url());
@@ -63,7 +65,7 @@ TEST_F(SavePageRequestTest, StartAndCompleteRequest) {
base::Time creation_time = base::Time::Now();
base::Time activation_time = creation_time + base::TimeDelta::FromHours(6);
SavePageRequest request(kRequestId, kUrl, kClientId, creation_time,
- activation_time);
+ activation_time, kUserRequested);
base::Time start_time = activation_time + base::TimeDelta::FromHours(3);
request.MarkAttemptStarted(start_time);

Powered by Google App Engine
This is Rietveld 408576698