Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2917)

Unified Diff: chrome/browser/file_select_helper.cc

Issue 2113353002: Fix file chooser on ChromeOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/file_select_helper.cc
diff --git a/chrome/browser/file_select_helper.cc b/chrome/browser/file_select_helper.cc
index 514ea628df2b9460b050acddc1cd07c3a0b6e54e..46c553886602bd4a2d376d238183f9fd18a02fe4 100644
--- a/chrome/browser/file_select_helper.cc
+++ b/chrome/browser/file_select_helper.cc
@@ -655,12 +655,14 @@ void FileSelectHelper::Observe(int type,
void FileSelectHelper::RenderFrameHostChanged(
content::RenderFrameHost* old_host,
content::RenderFrameHost* new_host) {
- render_frame_host_ = nullptr;
+ if (old_host == render_frame_host_)
+ render_frame_host_ = nullptr;
Charlie Reis 2016/07/01 21:50:18 Seems right. We should probably add a CleanUp cal
}
void FileSelectHelper::RenderFrameDeleted(
content::RenderFrameHost* render_frame_host) {
- render_frame_host_ = nullptr;
+ if (render_frame_host == render_frame_host_)
+ render_frame_host_ = nullptr;
}
void FileSelectHelper::WebContentsDestroyed() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698