Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Unified Diff: components/network_session_configurator/network_session_configurator.cc

Issue 2113343002: QUIC - added force_hol_blocking field trial param to enable forced HOL blocking. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@126418608
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/http_network_session.h » ('j') | net/quic/quic_stream_factory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/network_session_configurator/network_session_configurator.cc
diff --git a/components/network_session_configurator/network_session_configurator.cc b/components/network_session_configurator/network_session_configurator.cc
index a54ae4447fc3398665f33c08e7cdb46daf88cc14..d93850120abfed6f1a48a11da2b3881b44b195c0 100644
--- a/components/network_session_configurator/network_session_configurator.cc
+++ b/components/network_session_configurator/network_session_configurator.cc
@@ -268,6 +268,12 @@ bool ShouldQuicPreferAes(const VariationParameters& quic_trial_params) {
GetVariationParam(quic_trial_params, "prefer_aes"), "true");
}
+bool ShouldForceHolBlocking(const VariationParameters& quic_trial_params) {
+ return base::LowerCaseEqualsASCII(
+ GetVariationParam(quic_trial_params, "force_hol_blocking"), "true");
Ryan Hamilton 2016/07/01 21:32:26 Can you add a test in network_session_configurator
Buck 2016/07/08 22:17:09 Done.
+}
+
Ryan Hamilton 2016/07/01 21:32:27 nit: blank line
Buck 2016/07/08 22:17:09 Done.
+
int GetQuicMaxNumberOfLossyConnections(
const VariationParameters& quic_trial_params) {
int value;
@@ -441,6 +447,7 @@ void ConfigureQuicParams(const base::CommandLine& command_line,
params->quic_disable_disk_cache =
ShouldQuicDisableDiskCache(quic_trial_params);
params->quic_prefer_aes = ShouldQuicPreferAes(quic_trial_params);
+ params->quic_force_hol_blocking = ShouldForceHolBlocking(quic_trial_params);
int max_number_of_lossy_connections =
GetQuicMaxNumberOfLossyConnections(quic_trial_params);
if (max_number_of_lossy_connections != 0) {
« no previous file with comments | « no previous file | net/http/http_network_session.h » ('j') | net/quic/quic_stream_factory.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698