Change the x86{,_64} intrinsic targets in //third_party/libvpx to be source_sets.

Change the x86{,_64} intrinsic targets in //third_party/libvpx to be source_sets.

libvpx indirects exposure to the intrinsic implementations through function
pointer symbols, which on Mac creates an indirect dependency between the
archives. If an executable does not directly reference the libvpx symbols, and
neither -Wl,-all_load (to force the linker to load the objects) nor
-Wl,-dead_strip (to remove the unused objects) are present, then the linker
will complain about undefined symbols in the intrinsic targets referenced
from the libvpx target.

BUG=618797
R=tomfinegan@chromium.org

Committed: https://crrev.com/10dc9985f86b376124173a2967c7b2830a40792a
Cr-Commit-Position: refs/heads/master@{#403532}

[Johann, 2016-07-01 20:39:15]

johannkoenig@google.com changed reviewers:
+ johannkoenig@google.com

[Johann, 2016-07-01 20:39:15]

LGTM. Peeked at the build failures and can't see why they'd be from this change.

[Robert Sesek, 2016-07-01 20:41:57]

On 2016/07/01 20:39:15, Johann wrote:
> LGTM. Peeked at the build failures and can't see why they'd be from this
change.

Thanks. I did too; they both happened as main waterfall breakage as well, so not
related. (And the others are goma failures).

[Robert Sesek, 2016-07-01 20:42:04]

The CQ bit was checked by rsesek@chromium.org

[commit-bot: I haz the power, 2016-07-01 20:43:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 21:16:15]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-01 21:16:21]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-01 21:18:07]

Description was changed from

==========
Change the x86{,_64} intrinsic targets in //third_party/libvpx to be
source_sets.

libvpx indirects exposure to the intrinsic implementations through function
pointer symbols, which on Mac creates an indirect dependency between the
archives. If an executable does not directly reference the libvpx symbols, and
neither -Wl,-all_load (to force the linker to load the objects) nor
-Wl,-dead_strip (to remove the unused objects) are present, then the linker
will complain about undefined symbols in the intrinsic targets referenced
from the libvpx target.

BUG=618797
R=tomfinegan@chromium.org
==========

to

==========
Change the x86{,_64} intrinsic targets in //third_party/libvpx to be
source_sets.

libvpx indirects exposure to the intrinsic implementations through function
pointer symbols, which on Mac creates an indirect dependency between the
archives. If an executable does not directly reference the libvpx symbols, and
neither -Wl,-all_load (to force the linker to load the objects) nor
-Wl,-dead_strip (to remove the unused objects) are present, then the linker
will complain about undefined symbols in the intrinsic targets referenced
from the libvpx target.

BUG=618797
R=tomfinegan@chromium.org

Committed: https://crrev.com/10dc9985f86b376124173a2967c7b2830a40792a
Cr-Commit-Position: refs/heads/master@{#403532}
==========

[commit-bot: I haz the power, 2016-07-01 21:18:08]

Patchset 1 (id:??) landed as
https://crrev.com/10dc9985f86b376124173a2967c7b2830a40792a
Cr-Commit-Position: refs/heads/master@{#403532}