Issue 211333005: Launch easy unlock setup app from chrome://settings.

Issue 211333005: Launch easy unlock setup app from chrome://settings. (Closed)

Created:
6 years, 9 months ago by Tim Song

Modified:
6 years, 8 months ago

Reviewers:
xiyuan, Roger Tawa OOO till Jul 10th, Mattias Nissler (ping if slow), asargent_no_longer_on_chrome

CC:
chromium-reviews, dbeam+watch-options_chromium.org, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Launch easy unlock setup app from chrome://settings. BUG=347709 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260479

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -52 lines)			Patch
M	chrome/browser/prefs/browser_prefs.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
A	chrome/browser/signin/easy_unlock.h	View	1 chunk	+24 lines, -0 lines	0 comments	Download
A +	chrome/browser/signin/easy_unlock.cc	View	2 chunks	+20 lines, -3 lines	0 comments	Download
D	chrome/browser/signin/easy_unlock_controller.h	View	1 chunk	+0 lines, -18 lines	0 comments	Download
D	chrome/browser/signin/easy_unlock_controller.cc	View	1 chunk	+0 lines, -26 lines	0 comments	Download
M	chrome/browser/ui/webui/options/browser_options_handler.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/extension_constants.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension_constants.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Tim Song

+xiyuan@ for chrome/browser/ui +rogerta@ for chrome/browser/signin +mnissler@ for chrome/browser/prefs +asargent@ for chrome/common/extensions Please take a ...

6 years, 9 months ago (2014-03-26 01:55:43 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tengs@chromium.org/211333005/1

6 years, 8 months ago (2014-03-30 22:38:24 UTC) #7

Message was sent while issue was closed.

Change committed as 260479

Expand Messages | Collapse Messages