Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: Source/bindings/tests/results/V8TestInterfaceCustomConstructor.cpp

Issue 211333004: Tidy up error reporting for calling-constructor-as-function. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: re-use failedToConstruct() in constructorNotCallableAsFunction(). Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestInterfaceCustomConstructor.cpp
diff --git a/Source/bindings/tests/results/V8TestInterfaceCustomConstructor.cpp b/Source/bindings/tests/results/V8TestInterfaceCustomConstructor.cpp
index 54e5bec57b7eb5e4882340fe993d0657bd0f1d59..b3b28f9beed99841b9e18e5a4c4b13675dfff8a3 100644
--- a/Source/bindings/tests/results/V8TestInterfaceCustomConstructor.cpp
+++ b/Source/bindings/tests/results/V8TestInterfaceCustomConstructor.cpp
@@ -49,7 +49,7 @@ void V8TestInterfaceCustomConstructor::constructorCallback(const v8::FunctionCal
{
TRACE_EVENT_SCOPED_SAMPLING_STATE("Blink", "DOMConstructor");
if (!info.IsConstructCall()) {
- throwTypeError(ExceptionMessages::failedToConstruct("TestInterfaceCustomConstructor", "Please use the 'new' operator, this DOM object constructor cannot be called as a function."), info.GetIsolate());
+ throwTypeError(ExceptionMessages::constructorNotCallableAsFunction("TestInterfaceCustomConstructor"), info.GetIsolate());
return;
}

Powered by Google App Engine
This is Rietveld 408576698