Tidy up error reporting for calling-constructor-as-function.

Source/bindings/v8/ExceptionMessages.h

Index: Source/bindings/v8/ExceptionMessages.h
diff --git a/Source/bindings/v8/ExceptionMessages.h b/Source/bindings/v8/ExceptionMessages.h
index 85475609e719c741a9c2f58cb17abdb2d7b722a7..6a806ac55412fad348ce0eaa04dd7e73a2e65cfe 100644
--- a/Source/bindings/v8/ExceptionMessages.h
+++ b/Source/bindings/v8/ExceptionMessages.h
@@ -46,9 +46,9 @@ public:
         ExclusiveBound,
     };
 
-    static String failedToConstruct(const String& type, const String& detail = String());
-    static String failedToEnumerate(const String& type, const String& detail = String());
-    static String failedToExecute(const String& method, const String& type, const String& detail = String());
+    static String failedToConstruct(const String& type, const String& detail);

[Nils Barth (inactive), 2014/03/26 05:20:08]

Can you eliminate failedToConstruct?
AFAICT I think it's only used for the errors you've replaced.

[sof, 2014/03/26 06:18:58]

I don't think that's possible -- it's used in a number of places still (arity
checks, no matching overload.)

[Nils Barth (inactive), 2014/03/26 06:31:27]

Got it, you're right!
(Quick code search turned up the *first* match in files, which is the "not
callable as a function" error.)

+    static String failedToEnumerate(const String& type, const String& detail);
+    static String failedToExecute(const String& method, const String& type, const String& detail);
     static String failedToGet(const String& property, const String& type, const String& detail);
     static String failedToSet(const String& property, const String& type, const String& detail);
     static String failedToDelete(const String& property, const String& type, const String& detail);
@@ -56,6 +56,8 @@ public:
     static String failedToSetIndexed(const String& type, const String& detail);
     static String failedToDeleteIndexed(const String& type, const String& detail);
 
+    static String constructorNotCallableAsFunction(const String& type);

[Nils Barth (inactive), 2014/03/26 05:20:08]

Should we alphabetize these?

[sof, 2014/03/26 07:37:39]

Done.

+
     static String incorrectPropertyType(const String& property, const String& detail);
 
     static String argumentNullOrIncorrectType(int argumentIndex, const String& expectedType);