Tidy up error reporting for calling-constructor-as-function.

Source/bindings/v8/ExceptionMessages.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 28 matching lines @@
 
 class Decimal;
 
 class ExceptionMessages {
 public:
     enum BoundType {
         InclusiveBound,
         ExclusiveBound,
     };
 
-    static String failedToConstruct(const String& type, const String& detail = String());
-    static String failedToEnumerate(const String& type, const String& detail = String());
-    static String failedToExecute(const String& method, const String& type, const String& detail = String());
+    static String argumentNullOrIncorrectType(int argumentIndex, const String& expectedType);
+    static String constructorNotCallableAsFunction(const String& type);
+
+    static String failedToConstruct(const String& type, const String& detail);
+    static String failedToEnumerate(const String& type, const String& detail);
+    static String failedToExecute(const String& method, const String& type, const String& detail);
     static String failedToGet(const String& property, const String& type, const String& detail);
     static String failedToSet(const String& property, const String& type, const String& detail);
     static String failedToDelete(const String& property, const String& type, const String& detail);
     static String failedToGetIndexed(const String& type, const String& detail);
     static String failedToSetIndexed(const String& type, const String& detail);
     static String failedToDeleteIndexed(const String& type, const String& detail);
 
+    template <typename NumType>
+    static String formatNumber(NumType number)
+    {
+        return formatFiniteNumber(number);
+    }
+
     static String incorrectPropertyType(const String& property, const String& detail);
 
-    static String argumentNullOrIncorrectType(int argumentIndex, const String& expectedType);
-
-    // If  > 0, the argument index that failed type check (1-indexed.)
-    // If == 0, a (non-argument) value (e.g., a setter) failed the same check.
-    static String notAnArrayTypeArgumentOrValue(int argumentIndex);
-    static String notASequenceTypeProperty(const String& propertyName);
-    static String notAFiniteNumber(double value, const char* name = "value provided");
-    static String notAFiniteNumber(const Decimal& value, const char* name = "value provided");
-
-    static String notEnoughArguments(unsigned expected, unsigned providedleastNumMandatoryParams);
-
-    static String readOnly(const char* detail = 0);
-
     template <typename NumberType>
     static String indexExceedsMaximumBound(const char* name, NumberType given, NumberType bound)
     {
         bool eq = given == bound;
         StringBuilder result;
         result.append("The ");
         result.append(name);
         result.append(" provided (");
         result.append(formatNumber(given));
         result.append(") is greater than ");
@@ skipping 32 matching lines @@
         result.append(") is outside the range ");
         result.append(lowerType == ExclusiveBound ? '(' : '[');
         result.append(formatNumber(lowerBound));
         result.append(", ");
         result.append(formatNumber(upperBound));
         result.append(upperType == ExclusiveBound ? ')' : ']');
         result.append('.');
         return result.toString();
     }
 
-    template <typename NumType>
-    static String formatNumber(NumType number)
-    {
-        return formatFiniteNumber(number);
-    }
+    // If  > 0, the argument index that failed type check (1-indexed.)
+    // If == 0, a (non-argument) value (e.g., a setter) failed the same check.
+    static String notAnArrayTypeArgumentOrValue(int argumentIndex);
+    static String notASequenceTypeProperty(const String& propertyName);
+    static String notAFiniteNumber(double value, const char* name = "value provided");
+    static String notAFiniteNumber(const Decimal& value, const char* name = "value provided");
+
+    static String notEnoughArguments(unsigned expected, unsigned providedleastNumMandatoryParams);
+
+    static String readOnly(const char* detail = 0);
 
 private:
-    static String ordinalNumber(int number);
-
-
     template <typename NumType>
     static String formatFiniteNumber(NumType number)
     {
         if (number > 1e20 || number < -1e20)
             return String::format("%e", 1.0*number);
         return String::number(number);
     }
 
     template <typename NumType>
     static String formatPotentiallyNonFiniteNumber(NumType number)
     {
         if (std::isnan(number))
             return "NaN";
         if (std::isinf(number))
             return number > 0 ? "Infinity" : "-Infinity";
         if (number > 1e20 || number < -1e20)
             return String::format("%e", number);
         return String::number(number);
     }
+
+    static String ordinalNumber(int number);
 };
 
 template <> String ExceptionMessages::formatNumber<float>(float number);
 template <> String ExceptionMessages::formatNumber<double>(double number);
 
 } // namespace WebCore
 
 #endif // ExceptionMessages_h