Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: Source/bindings/tests/results/V8TestTypedefs.cpp

Issue 211333004: Tidy up error reporting for calling-constructor-as-function. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: re-use failedToConstruct() in constructorNotCallableAsFunction(). Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/tests/results/V8TestNode.cpp ('k') | Source/bindings/v8/ExceptionMessages.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file has been auto-generated by code_generator_v8.py. DO NOT MODIFY! 5 // This file has been auto-generated by code_generator_v8.py. DO NOT MODIFY!
6 6
7 #include "config.h" 7 #include "config.h"
8 #include "V8TestTypedefs.h" 8 #include "V8TestTypedefs.h"
9 9
10 #include "RuntimeEnabledFeatures.h" 10 #include "RuntimeEnabledFeatures.h"
(...skipping 416 matching lines...) Expand 10 before | Expand all | Expand 10 after
427 {"fooOrBarMethod", TestTypedefsV8Internal::fooOrBarMethodMethodCallback, 0, 0}, 427 {"fooOrBarMethod", TestTypedefsV8Internal::fooOrBarMethodMethodCallback, 0, 0},
428 {"stringArrayFunction", TestTypedefsV8Internal::stringArrayFunctionMethodCal lback, 0, 1}, 428 {"stringArrayFunction", TestTypedefsV8Internal::stringArrayFunctionMethodCal lback, 0, 1},
429 {"stringArrayFunction2", TestTypedefsV8Internal::stringArrayFunction2MethodC allback, 0, 1}, 429 {"stringArrayFunction2", TestTypedefsV8Internal::stringArrayFunction2MethodC allback, 0, 1},
430 {"methodWithException", TestTypedefsV8Internal::methodWithExceptionMethodCal lback, 0, 0}, 430 {"methodWithException", TestTypedefsV8Internal::methodWithExceptionMethodCal lback, 0, 0},
431 }; 431 };
432 432
433 void V8TestTypedefs::constructorCallback(const v8::FunctionCallbackInfo<v8::Valu e>& info) 433 void V8TestTypedefs::constructorCallback(const v8::FunctionCallbackInfo<v8::Valu e>& info)
434 { 434 {
435 TRACE_EVENT_SCOPED_SAMPLING_STATE("Blink", "DOMConstructor"); 435 TRACE_EVENT_SCOPED_SAMPLING_STATE("Blink", "DOMConstructor");
436 if (!info.IsConstructCall()) { 436 if (!info.IsConstructCall()) {
437 throwTypeError(ExceptionMessages::failedToConstruct("TestTypedefs", "Ple ase use the 'new' operator, this DOM object constructor cannot be called as a fu nction."), info.GetIsolate()); 437 throwTypeError(ExceptionMessages::constructorNotCallableAsFunction("Test Typedefs"), info.GetIsolate());
438 return; 438 return;
439 } 439 }
440 440
441 if (ConstructorMode::current() == ConstructorMode::WrapExistingObject) { 441 if (ConstructorMode::current() == ConstructorMode::WrapExistingObject) {
442 v8SetReturnValue(info, info.Holder()); 442 v8SetReturnValue(info, info.Holder());
443 return; 443 return;
444 } 444 }
445 445
446 TestTypedefsV8Internal::constructor(info); 446 TestTypedefsV8Internal::constructor(info);
447 } 447 }
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
519 fromInternalPointer(object)->deref(); 519 fromInternalPointer(object)->deref();
520 } 520 }
521 521
522 template<> 522 template<>
523 v8::Handle<v8::Value> toV8NoInline(TestTypedefs* impl, v8::Handle<v8::Object> cr eationContext, v8::Isolate* isolate) 523 v8::Handle<v8::Value> toV8NoInline(TestTypedefs* impl, v8::Handle<v8::Object> cr eationContext, v8::Isolate* isolate)
524 { 524 {
525 return toV8(impl, creationContext, isolate); 525 return toV8(impl, creationContext, isolate);
526 } 526 }
527 527
528 } // namespace WebCore 528 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/tests/results/V8TestNode.cpp ('k') | Source/bindings/v8/ExceptionMessages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698