Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Side by Side Diff: Source/bindings/tests/results/V8TestNode.cpp

Issue 211333004: Tidy up error reporting for calling-constructor-as-function. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: re-use failedToConstruct() in constructorNotCallableAsFunction(). Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file has been auto-generated by code_generator_v8.py. DO NOT MODIFY! 5 // This file has been auto-generated by code_generator_v8.py. DO NOT MODIFY!
6 6
7 #include "config.h" 7 #include "config.h"
8 #include "V8TestNode.h" 8 #include "V8TestNode.h"
9 9
10 #include "RuntimeEnabledFeatures.h" 10 #include "RuntimeEnabledFeatures.h"
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 static const V8DOMConfiguration::AttributeConfiguration V8TestNodeAttributes[] = { 141 static const V8DOMConfiguration::AttributeConfiguration V8TestNodeAttributes[] = {
142 {"href", TestNodeV8Internal::hrefAttributeGetterCallback, TestNodeV8Internal ::hrefAttributeSetterCallback, 0, 0, 0, static_cast<v8::AccessControl>(v8::DEFAU LT), static_cast<v8::PropertyAttribute>(v8::None), 0 /* on instance */}, 142 {"href", TestNodeV8Internal::hrefAttributeGetterCallback, TestNodeV8Internal ::hrefAttributeSetterCallback, 0, 0, 0, static_cast<v8::AccessControl>(v8::DEFAU LT), static_cast<v8::PropertyAttribute>(v8::None), 0 /* on instance */},
143 {"hrefThrows", TestNodeV8Internal::hrefThrowsAttributeGetterCallback, TestNo deV8Internal::hrefThrowsAttributeSetterCallback, 0, 0, 0, static_cast<v8::Access Control>(v8::DEFAULT), static_cast<v8::PropertyAttribute>(v8::None), 0 /* on ins tance */}, 143 {"hrefThrows", TestNodeV8Internal::hrefThrowsAttributeGetterCallback, TestNo deV8Internal::hrefThrowsAttributeSetterCallback, 0, 0, 0, static_cast<v8::Access Control>(v8::DEFAULT), static_cast<v8::PropertyAttribute>(v8::None), 0 /* on ins tance */},
144 {"hrefCallWith", TestNodeV8Internal::hrefCallWithAttributeGetterCallback, Te stNodeV8Internal::hrefCallWithAttributeSetterCallback, 0, 0, 0, static_cast<v8:: AccessControl>(v8::DEFAULT), static_cast<v8::PropertyAttribute>(v8::None), 0 /* on instance */}, 144 {"hrefCallWith", TestNodeV8Internal::hrefCallWithAttributeGetterCallback, Te stNodeV8Internal::hrefCallWithAttributeSetterCallback, 0, 0, 0, static_cast<v8:: AccessControl>(v8::DEFAULT), static_cast<v8::PropertyAttribute>(v8::None), 0 /* on instance */},
145 }; 145 };
146 146
147 void V8TestNode::constructorCallback(const v8::FunctionCallbackInfo<v8::Value>& info) 147 void V8TestNode::constructorCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
148 { 148 {
149 TRACE_EVENT_SCOPED_SAMPLING_STATE("Blink", "DOMConstructor"); 149 TRACE_EVENT_SCOPED_SAMPLING_STATE("Blink", "DOMConstructor");
150 if (!info.IsConstructCall()) { 150 if (!info.IsConstructCall()) {
151 throwTypeError(ExceptionMessages::failedToConstruct("TestNode", "Please use the 'new' operator, this DOM object constructor cannot be called as a functi on."), info.GetIsolate()); 151 throwTypeError(ExceptionMessages::constructorNotCallableAsFunction("Test Node"), info.GetIsolate());
152 return; 152 return;
153 } 153 }
154 154
155 if (ConstructorMode::current() == ConstructorMode::WrapExistingObject) { 155 if (ConstructorMode::current() == ConstructorMode::WrapExistingObject) {
156 v8SetReturnValue(info, info.Holder()); 156 v8SetReturnValue(info, info.Holder());
157 return; 157 return;
158 } 158 }
159 159
160 TestNodeV8Internal::constructor(info); 160 TestNodeV8Internal::constructor(info);
161 } 161 }
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
238 fromInternalPointer(object)->deref(); 238 fromInternalPointer(object)->deref();
239 } 239 }
240 240
241 template<> 241 template<>
242 v8::Handle<v8::Value> toV8NoInline(TestNode* impl, v8::Handle<v8::Object> creati onContext, v8::Isolate* isolate) 242 v8::Handle<v8::Value> toV8NoInline(TestNode* impl, v8::Handle<v8::Object> creati onContext, v8::Isolate* isolate)
243 { 243 {
244 return toV8(impl, creationContext, isolate); 244 return toV8(impl, creationContext, isolate);
245 } 245 }
246 246
247 } // namespace WebCore 247 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698