Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: Source/bindings/tests/results/V8TestInterfacePython2.cpp

Issue 211333004: Tidy up error reporting for calling-constructor-as-function. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: re-use failedToConstruct() in constructorNotCallableAsFunction(). Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file has been auto-generated by code_generator_v8.py. DO NOT MODIFY! 5 // This file has been auto-generated by code_generator_v8.py. DO NOT MODIFY!
6 6
7 #include "config.h" 7 #include "config.h"
8 #include "V8TestInterfacePython2.h" 8 #include "V8TestInterfacePython2.h"
9 9
10 #include "RuntimeEnabledFeatures.h" 10 #include "RuntimeEnabledFeatures.h"
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 isolate->SetReferenceFromGroup(v8::UniqueId(reinterpret_cast<intptr_t>(r oot)), wrapper); 67 isolate->SetReferenceFromGroup(v8::UniqueId(reinterpret_cast<intptr_t>(r oot)), wrapper);
68 return; 68 return;
69 } 69 }
70 setObjectGroup(object, wrapper, isolate); 70 setObjectGroup(object, wrapper, isolate);
71 } 71 }
72 72
73 void V8TestInterfacePython2::constructorCallback(const v8::FunctionCallbackInfo< v8::Value>& info) 73 void V8TestInterfacePython2::constructorCallback(const v8::FunctionCallbackInfo< v8::Value>& info)
74 { 74 {
75 TRACE_EVENT_SCOPED_SAMPLING_STATE("Blink", "DOMConstructor"); 75 TRACE_EVENT_SCOPED_SAMPLING_STATE("Blink", "DOMConstructor");
76 if (!info.IsConstructCall()) { 76 if (!info.IsConstructCall()) {
77 throwTypeError(ExceptionMessages::failedToConstruct("TestInterfacePython 2", "Please use the 'new' operator, this DOM object constructor cannot be called as a function."), info.GetIsolate()); 77 throwTypeError(ExceptionMessages::constructorNotCallableAsFunction("Test InterfacePython2"), info.GetIsolate());
78 return; 78 return;
79 } 79 }
80 80
81 if (ConstructorMode::current() == ConstructorMode::WrapExistingObject) { 81 if (ConstructorMode::current() == ConstructorMode::WrapExistingObject) {
82 v8SetReturnValue(info, info.Holder()); 82 v8SetReturnValue(info, info.Holder());
83 return; 83 return;
84 } 84 }
85 85
86 TestInterfacePython2V8Internal::constructor(info); 86 TestInterfacePython2V8Internal::constructor(info);
87 } 87 }
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 fromInternalPointer(object)->deref(); 170 fromInternalPointer(object)->deref();
171 } 171 }
172 172
173 template<> 173 template<>
174 v8::Handle<v8::Value> toV8NoInline(TestInterfacePython2* impl, v8::Handle<v8::Ob ject> creationContext, v8::Isolate* isolate) 174 v8::Handle<v8::Value> toV8NoInline(TestInterfacePython2* impl, v8::Handle<v8::Ob ject> creationContext, v8::Isolate* isolate)
175 { 175 {
176 return toV8(impl, creationContext, isolate); 176 return toV8(impl, creationContext, isolate);
177 } 177 }
178 178
179 } // namespace WebCore 179 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698