Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Side by Side Diff: Source/bindings/tests/results/V8TestInterfaceConstructor3.cpp

Issue 211333004: Tidy up error reporting for calling-constructor-as-function. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: re-use failedToConstruct() in constructorNotCallableAsFunction(). Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file has been auto-generated by code_generator_v8.py. DO NOT MODIFY! 5 // This file has been auto-generated by code_generator_v8.py. DO NOT MODIFY!
6 6
7 #include "config.h" 7 #include "config.h"
8 #include "V8TestInterfaceConstructor3.h" 8 #include "V8TestInterfaceConstructor3.h"
9 9
10 #include "RuntimeEnabledFeatures.h" 10 #include "RuntimeEnabledFeatures.h"
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 V8DOMWrapper::associateObjectWithWrapper<V8TestInterfaceConstructor3>(impl.r elease(), &V8TestInterfaceConstructor3::wrapperTypeInfo, wrapper, isolate, Wrapp erConfiguration::Independent); 57 V8DOMWrapper::associateObjectWithWrapper<V8TestInterfaceConstructor3>(impl.r elease(), &V8TestInterfaceConstructor3::wrapperTypeInfo, wrapper, isolate, Wrapp erConfiguration::Independent);
58 v8SetReturnValue(info, wrapper); 58 v8SetReturnValue(info, wrapper);
59 } 59 }
60 60
61 } // namespace TestInterfaceConstructor3V8Internal 61 } // namespace TestInterfaceConstructor3V8Internal
62 62
63 void V8TestInterfaceConstructor3::constructorCallback(const v8::FunctionCallback Info<v8::Value>& info) 63 void V8TestInterfaceConstructor3::constructorCallback(const v8::FunctionCallback Info<v8::Value>& info)
64 { 64 {
65 TRACE_EVENT_SCOPED_SAMPLING_STATE("Blink", "DOMConstructor"); 65 TRACE_EVENT_SCOPED_SAMPLING_STATE("Blink", "DOMConstructor");
66 if (!info.IsConstructCall()) { 66 if (!info.IsConstructCall()) {
67 throwTypeError(ExceptionMessages::failedToConstruct("TestInterfaceConstr uctor3", "Please use the 'new' operator, this DOM object constructor cannot be c alled as a function."), info.GetIsolate()); 67 throwTypeError(ExceptionMessages::constructorNotCallableAsFunction("Test InterfaceConstructor3"), info.GetIsolate());
68 return; 68 return;
69 } 69 }
70 70
71 if (ConstructorMode::current() == ConstructorMode::WrapExistingObject) { 71 if (ConstructorMode::current() == ConstructorMode::WrapExistingObject) {
72 v8SetReturnValue(info, info.Holder()); 72 v8SetReturnValue(info, info.Holder());
73 return; 73 return;
74 } 74 }
75 75
76 TestInterfaceConstructor3V8Internal::constructor(info); 76 TestInterfaceConstructor3V8Internal::constructor(info);
77 } 77 }
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 fromInternalPointer(object)->deref(); 149 fromInternalPointer(object)->deref();
150 } 150 }
151 151
152 template<> 152 template<>
153 v8::Handle<v8::Value> toV8NoInline(TestInterfaceConstructor3* impl, v8::Handle<v 8::Object> creationContext, v8::Isolate* isolate) 153 v8::Handle<v8::Value> toV8NoInline(TestInterfaceConstructor3* impl, v8::Handle<v 8::Object> creationContext, v8::Isolate* isolate)
154 { 154 {
155 return toV8(impl, creationContext, isolate); 155 return toV8(impl, creationContext, isolate);
156 } 156 }
157 157
158 } // namespace WebCore 158 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698