Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Side by Side Diff: Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp

Issue 211333004: Tidy up error reporting for calling-constructor-as-function. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: re-use failedToConstruct() in constructorNotCallableAsFunction(). Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file has been auto-generated by code_generator_v8.py. DO NOT MODIFY! 5 // This file has been auto-generated by code_generator_v8.py. DO NOT MODIFY!
6 6
7 #include "config.h" 7 #include "config.h"
8 #include "V8TestInterfaceConstructor2.h" 8 #include "V8TestInterfaceConstructor2.h"
9 9
10 #include "RuntimeEnabledFeatures.h" 10 #include "RuntimeEnabledFeatures.h"
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 exceptionState.throwTypeError("No matching constructor signature."); 96 exceptionState.throwTypeError("No matching constructor signature.");
97 exceptionState.throwIfNeeded(); 97 exceptionState.throwIfNeeded();
98 } 98 }
99 99
100 } // namespace TestInterfaceConstructor2V8Internal 100 } // namespace TestInterfaceConstructor2V8Internal
101 101
102 void V8TestInterfaceConstructor2::constructorCallback(const v8::FunctionCallback Info<v8::Value>& info) 102 void V8TestInterfaceConstructor2::constructorCallback(const v8::FunctionCallback Info<v8::Value>& info)
103 { 103 {
104 TRACE_EVENT_SCOPED_SAMPLING_STATE("Blink", "DOMConstructor"); 104 TRACE_EVENT_SCOPED_SAMPLING_STATE("Blink", "DOMConstructor");
105 if (!info.IsConstructCall()) { 105 if (!info.IsConstructCall()) {
106 throwTypeError(ExceptionMessages::failedToConstruct("TestInterfaceConstr uctor2", "Please use the 'new' operator, this DOM object constructor cannot be c alled as a function."), info.GetIsolate()); 106 throwTypeError(ExceptionMessages::constructorNotCallableAsFunction("Test InterfaceConstructor2"), info.GetIsolate());
107 return; 107 return;
108 } 108 }
109 109
110 if (ConstructorMode::current() == ConstructorMode::WrapExistingObject) { 110 if (ConstructorMode::current() == ConstructorMode::WrapExistingObject) {
111 v8SetReturnValue(info, info.Holder()); 111 v8SetReturnValue(info, info.Holder());
112 return; 112 return;
113 } 113 }
114 114
115 TestInterfaceConstructor2V8Internal::constructor(info); 115 TestInterfaceConstructor2V8Internal::constructor(info);
116 } 116 }
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
188 fromInternalPointer(object)->deref(); 188 fromInternalPointer(object)->deref();
189 } 189 }
190 190
191 template<> 191 template<>
192 v8::Handle<v8::Value> toV8NoInline(TestInterfaceConstructor2* impl, v8::Handle<v 8::Object> creationContext, v8::Isolate* isolate) 192 v8::Handle<v8::Value> toV8NoInline(TestInterfaceConstructor2* impl, v8::Handle<v 8::Object> creationContext, v8::Isolate* isolate)
193 { 193 {
194 return toV8(impl, creationContext, isolate); 194 return toV8(impl, creationContext, isolate);
195 } 195 }
196 196
197 } // namespace WebCore 197 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698