Tidy up error reporting for calling-constructor-as-function.

Source/bindings/v8/ExceptionMessages.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 28 matching lines @@
 
 class Decimal;
 
 class ExceptionMessages {
 public:
     enum BoundType {
         InclusiveBound,
         ExclusiveBound,
     };
 
-    static String failedToConstruct(const String& type, const String& detail = String());
-    static String failedToEnumerate(const String& type, const String& detail = String());
-    static String failedToExecute(const String& method, const String& type, const String& detail = String());
+    static String failedToConstruct(const String& type, const String& detail);

[Nils Barth (inactive), 2014/03/26 05:20:08]

Can you eliminate failedToConstruct?
AFAICT I think it's only used for the errors you've replaced.

[sof, 2014/03/26 06:18:58]

I don't think that's possible -- it's used in a number of places still (arity
checks, no matching overload.)

[Nils Barth (inactive), 2014/03/26 06:31:27]

Got it, you're right!
(Quick code search turned up the *first* match in files, which is the "not
callable as a function" error.)

+    static String failedToEnumerate(const String& type, const String& detail);
+    static String failedToExecute(const String& method, const String& type, const String& detail);
     static String failedToGet(const String& property, const String& type, const String& detail);
     static String failedToSet(const String& property, const String& type, const String& detail);
     static String failedToDelete(const String& property, const String& type, const String& detail);
     static String failedToGetIndexed(const String& type, const String& detail);
     static String failedToSetIndexed(const String& type, const String& detail);
     static String failedToDeleteIndexed(const String& type, const String& detail);
 
+    static String constructorNotCallableAsFunction(const String& type);

[Nils Barth (inactive), 2014/03/26 05:20:08]

Should we alphabetize these?

[sof, 2014/03/26 07:37:39]

Done.

+
     static String incorrectPropertyType(const String& property, const String& detail);
 
     static String argumentNullOrIncorrectType(int argumentIndex, const String& expectedType);
 
     // If  > 0, the argument index that failed type check (1-indexed.)
     // If == 0, a (non-argument) value (e.g., a setter) failed the same check.
     static String notAnArrayTypeArgumentOrValue(int argumentIndex);
     static String notASequenceTypeProperty(const String& propertyName);
     static String notAFiniteNumber(double value, const char* name = "value provided");
     static String notAFiniteNumber(const Decimal& value, const char* name = "value provided");
@@ skipping 84 matching lines @@
         return String::number(number);
     }
 };
 
 template <> String ExceptionMessages::formatNumber<float>(float number);
 template <> String ExceptionMessages::formatNumber<double>(double number);
 
 } // namespace WebCore
 
 #endif // ExceptionMessages_h