Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 211333003: Restore attribute array length in RecursionCheckPoint. (Closed)

Created:
6 years, 9 months ago by rune
Modified:
6 years, 9 months ago
Reviewers:
chrishtr, esprehn
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis, chrishtr
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Restore attribute array length in RecursionCheckPoint. Missing restore caused unnecessary invalidations in subsequent subtrees. Also renamed a misnamed parameter in RuleFeature.h R=esprehn BUG=356196 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169958

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -1 line) Patch
A LayoutTests/fast/css/invalidation/targeted-attribute-scope.html View 1 chunk +24 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/invalidation/targeted-attribute-scope-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/css/RuleFeature.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/invalidation/StyleInvalidator.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rune
6 years, 9 months ago (2014-03-25 15:15:55 UTC) #1
esprehn
lgtm
6 years, 9 months ago (2014-03-25 15:30:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/211333003/1
6 years, 9 months ago (2014-03-25 15:30:28 UTC) #3
chrishtr
lgtm
6 years, 9 months ago (2014-03-25 16:27:59 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 16:37:04 UTC) #5
Message was sent while issue was closed.
Change committed as 169958

Powered by Google App Engine
This is Rietveld 408576698