Chromium Code Reviews| Index: test/cctest/test-heap-profiler.cc |
| diff --git a/test/cctest/test-heap-profiler.cc b/test/cctest/test-heap-profiler.cc |
| index f1ccc571dabcfef9766da81c7f6a367cef469838..58a70c5abb4489acff94535468ff837711b162d7 100644 |
| --- a/test/cctest/test-heap-profiler.cc |
| +++ b/test/cctest/test-heap-profiler.cc |
| @@ -1602,7 +1602,7 @@ TEST(GetHeapValueForNode) { |
| v8::HandleScope scope(env->GetIsolate()); |
| v8::HeapProfiler* heap_profiler = env->GetIsolate()->GetHeapProfiler(); |
| - CompileRun("a = { s_prop: \'value\', n_prop: 0.1 };"); |
| + CompileRun("a = { s_prop: \'value\', n_prop: \'value2\' };"); |
| const v8::HeapSnapshot* snapshot = |
| heap_profiler->TakeHeapSnapshot(v8_str("value")); |
| CHECK(ValidateSnapshot(snapshot)); |
| @@ -1623,10 +1623,9 @@ TEST(GetHeapValueForNode) { |
| CHECK(js_s_prop == heap_profiler->FindObjectById(s_prop->GetId())); |
| const v8::HeapGraphNode* n_prop = |
| GetProperty(obj, v8::HeapGraphEdge::kProperty, "n_prop"); |
| - v8::Local<v8::Number> js_n_prop = |
| - js_obj->Get(v8_str("n_prop")).As<v8::Number>(); |
| - CHECK(js_n_prop->NumberValue() == |
| - heap_profiler->FindObjectById(n_prop->GetId())->NumberValue()); |
| + v8::Local<v8::String> js_n_prop = |
| + js_obj->Get(v8_str("n_prop")).As<v8::String>(); |
| + CHECK(js_n_prop == heap_profiler->FindObjectById(n_prop->GetId())); |
|
Igor Sheludko
2014/03/31 11:19:05
Probably it would be less confusing to check that
|
| } |