src/heap-snapshot-generator.cc - Issue 211333002: Replace HeapNumber as doublebox with an explicit MutableHeapNumber.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap-snapshot-generator.cc

Issue 211333002: Replace HeapNumber as doublebox with an explicit MutableHeapNumber. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap-snapshot-generator.cc

diff --git a/src/heap-snapshot-generator.cc b/src/heap-snapshot-generator.cc

index 332d0dbf6ff3705318f28a666d7134667e12295c..42ed56f98b5be1db6d172012379d205e076e4a2a 100644

--- a/src/heap-snapshot-generator.cc

+++ b/src/heap-snapshot-generator.cc

@@ -1591,6 +1591,8 @@ void V8HeapExplorer::ExtractPropertyReferences(JSObject* js_obj, int entry) {

for (int i = 0; i < real_size; i++) {

switch (descs->GetType(i)) {

case FIELD: {

+ Representation r = descs->GetDetails(i).representation();

+ if (r.IsSmi() || r.IsDouble()) break;

int index = descs->GetFieldIndex(i);

Name* k = descs->GetKey(i);

« no previous file with comments | « src/heap-inl.h ('k') | src/hydrogen.cc » ('j') | src/json-parser.h » ('J')