Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2113303002: Use bounds of batches for render pass bounds (Closed)

Created:
4 years, 5 months ago by egdaniel
Modified:
4 years, 5 months ago
Reviewers:
jvanverth1, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use bounds of batches for render pass bounds BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2113303002 Committed: https://skia.googlesource.com/skia/+/e7d1b24ff0a04686aef54fcb9feaca7a03e19891

Patch Set 1 #

Patch Set 2 : Fix int to scalar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -13 lines) Patch
M src/gpu/GrDrawTarget.cpp View 1 3 chunks +23 lines, -12 lines 0 comments Download
M src/gpu/vk/GrVkGpu.cpp View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
egdaniel
4 years, 5 months ago (2016-07-01 13:43:17 UTC) #3
jvanverth1
lgtm
4 years, 5 months ago (2016-07-01 13:54:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2113303002/1
4 years, 5 months ago (2016-07-01 14:01:35 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/9512)
4 years, 5 months ago (2016-07-01 14:08:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2113303002/20001
4 years, 5 months ago (2016-07-01 14:47:37 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 15:06:49 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e7d1b24ff0a04686aef54fcb9feaca7a03e19891

Powered by Google App Engine
This is Rietveld 408576698