Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: tracing/tracing/metrics/system_health/responsiveness_metric.html

Issue 2113253002: [Perf Impact] Make frame time discrepancy absolute. (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/metrics/system_health/responsiveness_metric.html
diff --git a/tracing/tracing/metrics/system_health/responsiveness_metric.html b/tracing/tracing/metrics/system_health/responsiveness_metric.html
index 5098c535277ddf12329cd935491e86ab4f80a017..81105c67c54a95f536c3e90eca7a144208c73a87 100644
--- a/tracing/tracing/metrics/system_health/responsiveness_metric.html
+++ b/tracing/tracing/metrics/system_health/responsiveness_metric.html
@@ -49,7 +49,7 @@ tr.exportTo('tr.metrics.sh', function() {
return event.start;
});
- var absolute = false;
+ var absolute = true;
return tr.b.Statistics.timestampsDiscrepancy(frameTimestamps, absolute);
}
@@ -61,9 +61,10 @@ tr.exportTo('tr.metrics.sh', function() {
tr.v.Unit.byName.unitlessNumber_biggerIsBetter,
tr.b.Range.fromExplicitRange(10, 60), 10);
- var DISCREPANCY_NUMERIC_BUILDER = tr.v.NumericBuilder.createLinear(
- tr.v.Unit.byName.unitlessNumber_smallerIsBetter,
- tr.b.Range.fromExplicitRange(0, 1), 50);
+ var DISCREPANCY_NUMERIC_BUILDER = new tr.v.NumericBuilder(
+ tr.v.Unit.byName.timeDurationInMs_smallerIsBetter, 0)
+ .addLinearBins(1000, 50) // 20ms step to 1s
+ .addExponentialBins(10000, 10);
var LATENCY_NUMERIC_BUILDER = tr.v.NumericBuilder.createLinear(
tr.v.Unit.byName.timeDurationInMs_smallerIsBetter,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698