Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 21132: Adds a unit test for NavigationEntry. Also adds a comment to BrowsingInstanc... (Closed)

Created:
11 years, 10 months ago by Charlie Reis
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Adds a unit test for NavigationEntry. Also adds a comment to BrowsingInstance to explain that it is unit tested in site_instance_unittest.cc. BUG=7371 BUG=7369 TEST=NavigationEntryTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9349

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -1 line) Patch
M chrome/browser/browsing_instance.h View 1 1 chunk +3 lines, -1 line 0 comments Download
A chrome/browser/navigation_entry_unittest.cc View 1 1 chunk +181 lines, -0 lines 0 comments Download
M chrome/test/unit/unittests.vcproj View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Charlie Reis
Hi Brett-- Could you review this unit test for NavigationEntry (and comment for the test ...
11 years, 10 months ago (2009-02-06 19:03:36 UTC) #1
brettw
Jolly good change. Looks ducky to me. http://codereview.chromium.org/21132/diff/1/4 File chrome/browser/navigation_entry_unittest.cc (right): http://codereview.chromium.org/21132/diff/1/4#newcode1 Line 1: // ...
11 years, 10 months ago (2009-02-06 19:10:46 UTC) #2
Charlie Reis
Great, thanks. http://codereview.chromium.org/21132/diff/1/4 File chrome/browser/navigation_entry_unittest.cc (right): http://codereview.chromium.org/21132/diff/1/4#newcode1 Line 1: // Copyright (c) 2006-2008 The Chromium ...
11 years, 10 months ago (2009-02-06 22:41:45 UTC) #3
pink (ping after 24hrs)
11 years, 10 months ago (2009-02-09 17:20:53 UTC) #4
why was this added to chrome/browser? NavigationEntry lives is
chrome/browser/tab_contents.

Can this be moved?

Powered by Google App Engine
This is Rietveld 408576698