Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 2113183006: Add timeout to the MessageLoop in FilePathWatcherTest (Closed)

Created:
4 years, 5 months ago by xyzzyz
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add timeout to the MessageLoop in FilePathWatcherTest BUG=625345 Committed: https://crrev.com/00d5c7678c5c0df674dbc216dafeb5574a6f1e0a Cr-Commit-Position: refs/heads/master@{#403936}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M base/files/file_path_watcher_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
xyzzyz
Hi Lei and Nico, I added a timeout to FilePathWatcherTest, so that if the Watcher ...
4 years, 5 months ago (2016-07-06 17:26:15 UTC) #3
Lei Zhang
lgtm
4 years, 5 months ago (2016-07-06 17:55:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2113183006/1
4 years, 5 months ago (2016-07-06 17:59:57 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 18:48:29 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 18:51:34 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/00d5c7678c5c0df674dbc216dafeb5574a6f1e0a
Cr-Commit-Position: refs/heads/master@{#403936}

Powered by Google App Engine
This is Rietveld 408576698