Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: src/wasm/wasm-module.cc

Issue 2113183002: [wasm] Fix possible gc-ing of wasm import code objects (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: better fix Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/wasm/wasm-module.cc
diff --git a/src/wasm/wasm-module.cc b/src/wasm/wasm-module.cc
index 3fcd2232c3846c66e4c7f626eb38f1a57d363067..ddc2eba7c852e471d12a240411f4fa205ed0aefc 100644
--- a/src/wasm/wasm-module.cc
+++ b/src/wasm/wasm-module.cc
@@ -372,7 +372,8 @@ bool LinkFunction(Handle<Code> unlinked,
Handle<Code> new_target = code_targets[index];
if (target != *new_target) {
it.rinfo()->set_target_address(new_target->instruction_start(),
- SKIP_WRITE_BARRIER, SKIP_ICACHE_FLUSH);
+ UPDATE_WRITE_BARRIER,
+ SKIP_ICACHE_FLUSH);
modified = true;
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698