Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2113143004: Switch to OpenSSL's |EVP_PKEY_up_ref| signature. (Closed)

Created:
4 years, 5 months ago by agl
Modified:
4 years, 5 months ago
Reviewers:
davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch to OpenSSL's |EVP_PKEY_up_ref| signature. |EVP_PKEY_up_ref| was a BoringSSL addition to OpenSSL The next major, public OpenSSL release will include it, but it'll return 0/1 rather than the object being referenced. This change updates Chromium to expect that function signature (in a backwards compatible way). Once all callers have been updated likewise, BoringSSL will align this function with upstream OpenSSL. BUG=none Committed: https://crrev.com/5a7cadf199b6b08ed39dede7cd83b0177936e033 Cr-Commit-Position: refs/heads/master@{#405192}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
M crypto/ec_private_key.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M crypto/rsa_private_key.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/socket/ssl_server_socket_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/ssl/openssl_client_key_store.cc View 2 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
agl
4 years, 5 months ago (2016-07-01 22:59:39 UTC) #2
davidben
lgtm
4 years, 5 months ago (2016-07-01 23:15:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2113143004/1
4 years, 5 months ago (2016-07-12 17:34:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/191507)
4 years, 5 months ago (2016-07-12 19:06:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2113143004/1
4 years, 5 months ago (2016-07-12 19:10:18 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/200080)
4 years, 5 months ago (2016-07-12 19:36:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2113143004/1
4 years, 5 months ago (2016-07-12 20:00:47 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/191664)
4 years, 5 months ago (2016-07-13 01:12:12 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2113143004/1
4 years, 5 months ago (2016-07-13 15:45:28 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 16:53:07 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 16:55:18 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a7cadf199b6b08ed39dede7cd83b0177936e033
Cr-Commit-Position: refs/heads/master@{#405192}

Powered by Google App Engine
This is Rietveld 408576698