Issue 211313003: Fix crash when creating an ImageBitmap from an invalid canvas

Issue 211313003: Fix crash when creating an ImageBitmap from an invalid canvas (Closed)

Created:
6 years, 9 months ago by Justin Novosad

Modified:
6 years, 9 months ago

Reviewers:
Stephen White, dglazkov, abarth-chromium

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Fix crash when creating an ImageBitmap from an invalid canvas BUG=354356 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169973

Patch Set 2 : staticity reinstalment #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -8 lines)			Patch
M	LayoutTests/fast/canvas/canvas-createImageBitmap-invalid-args.html	View		4 chunks	+38 lines, -6 lines	0 comments	Download
M	LayoutTests/fast/canvas/canvas-createImageBitmap-invalid-args-expected.txt	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/modules/imagebitmap/ImageBitmapFactories.cpp	View	1	2 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 12 (0 generated)

Expand Messages | Collapse Messages

Stephen White

https://codereview.chromium.org/211313003/diff/1/Source/modules/imagebitmap/ImageBitmapFactories.cpp File Source/modules/imagebitmap/ImageBitmapFactories.cpp (right): https://codereview.chromium.org/211313003/diff/1/Source/modules/imagebitmap/ImageBitmapFactories.cpp#newcode66 Source/modules/imagebitmap/ImageBitmapFactories.cpp:66: ScriptPromise fulfillImageBitmap(ExecutionContext* context, PassRefPtrWillBeRawPtr<ImageBitmap> imageBitmap) Is there a reason ...

6 years, 9 months ago (2014-03-25 16:56:30 UTC) #2

Justin Novosad

On 2014/03/25 16:56:30, Stephen White wrote: > https://codereview.chromium.org/211313003/diff/1/Source/modules/imagebitmap/ImageBitmapFactories.cpp > File Source/modules/imagebitmap/ImageBitmapFactories.cpp (right): > > https://codereview.chromium.org/211313003/diff/1/Source/modules/imagebitmap/ImageBitmapFactories.cpp#newcode66 ...

6 years, 9 months ago (2014-03-25 17:30:57 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/junov@chromium.org/211313003/80001

6 years, 9 months ago (2014-03-25 17:52:10 UTC) #6

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 9 months ago (2014-03-25 17:54:41 UTC) #7

commit-bot: I haz the power

Try jobs failed on following builders: tryserver.blink on blink_presubmit

6 years, 9 months ago (2014-03-25 17:54:42 UTC) #8

Justin Novosad

Oh, looks like I am missing a Source/modules owner's approval. Adding reviewers.

6 years, 9 months ago (2014-03-25 18:09:17 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/junov@chromium.org/211313003/80001

6 years, 9 months ago (2014-03-25 18:17:39 UTC) #11

Message was sent while issue was closed.

Change committed as 169973

Expand Messages | Collapse Messages