Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2113053003: Moves Shell::maximize_mode_controller() to WmShell (Closed)

Created:
4 years, 5 months ago by sky
Modified:
4 years, 5 months ago
Reviewers:
James Cook, Yusuke Sato
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, extensions-reviews_chromium.org, lhchavez+watch_chromium.org, sadrul, yusukes+watch_chromium.org, mlamouri+watch-screen-orientation_chromium.org, tfarina, hidehiko+watch_chromium.org, jam, dcheng, darin-cc_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves Shell::maximize_mode_controller() to WmShell BUG=612629 TEST=covered by tests R=jamescook@chromium.org TBR=yusukes@chromium.org Committed: https://crrev.com/c68696cc6a6fb8e052842e81905cf92777de47d2 Cr-Commit-Position: refs/heads/master@{#403529}

Patch Set 1 #

Total comments: 3

Patch Set 2 : order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -236 lines) Patch
M ash/accelerators/debug_commands.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/app_list/app_list_presenter_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/wm_shell.h View 4 chunks +9 lines, -0 lines 0 comments Download
M ash/common/wm_shell.cc View 1 2 chunks +9 lines, -0 lines 0 comments Download
M ash/content/display/screen_orientation_controller_chromeos_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/display/screen_orientation_controller_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/frame/caption_buttons/frame_caption_button_container_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/frame/caption_buttons/frame_caption_button_container_view_unittest.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M ash/frame/custom_frame_view_ash_unittest.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M ash/mus/bridge/wm_shell_mus.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M ash/shell.h View 3 chunks +0 lines, -7 lines 0 comments Download
M ash/shell.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/brightness/tray_brightness.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/brightness/tray_brightness_unittest.cc View 3 chunks +17 lines, -24 lines 0 comments Download
M ash/system/chromeos/rotation/tray_rotation_lock.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc View 7 chunks +32 lines, -46 lines 0 comments Download
M ash/system/overview/overview_button_tray.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M ash/system/overview/overview_button_tray_unittest.cc View 6 chunks +22 lines, -33 lines 0 comments Download
M ash/virtual_keyboard_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/virtual_keyboard_controller_unittest.cc View 6 chunks +15 lines, -22 lines 0 comments Download
M ash/wm/lock_state_controller_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc View 24 chunks +35 lines, -41 lines 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ash/wm/power_button_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/display/display_preferences_unittest.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/display_info_provider_chromeos_unittest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/touch_view_controller_delegate.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/arc/window_manager/arc_window_manager_bridge.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
sky
yusukes: arc james: the rest
4 years, 5 months ago (2016-07-01 19:34:24 UTC) #3
James Cook
LGTM https://codereview.chromium.org/2113053003/diff/1/ash/common/wm_shell.cc File ash/common/wm_shell.cc (right): https://codereview.chromium.org/2113053003/diff/1/ash/common/wm_shell.cc#newcode125 ash/common/wm_shell.cc:125: void WmShell::CreateMaximizeModeController() { nit: Match header file order ...
4 years, 5 months ago (2016-07-01 20:09:10 UTC) #4
sky
https://codereview.chromium.org/2113053003/diff/1/ash/common/wm_shell.cc File ash/common/wm_shell.cc (right): https://codereview.chromium.org/2113053003/diff/1/ash/common/wm_shell.cc#newcode125 ash/common/wm_shell.cc:125: void WmShell::CreateMaximizeModeController() { On 2016/07/01 20:09:09, James Cook wrote: ...
4 years, 5 months ago (2016-07-01 20:13:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2113053003/20001
4 years, 5 months ago (2016-07-01 20:14:58 UTC) #8
sky
TBR for yusukes.
4 years, 5 months ago (2016-07-01 20:18:57 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-01 21:06:15 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-01 21:06:21 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 21:07:20 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/c68696cc6a6fb8e052842e81905cf92777de47d2
Cr-Commit-Position: refs/heads/master@{#403529}

Powered by Google App Engine
This is Rietveld 408576698