third_party/closure_compiler/README.chromium - Issue 2113053002: Make Chrome-specific enhancements optional in runner.jar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/closure_compiler/README.chromium

Issue 2113053002: Make Chrome-specific enhancements optional in runner.jar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update README Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/closure_compiler/runner/src/org/chromium/closure/compiler/Runner.java » ('j') | third_party/closure_compiler/runner/src/org/chromium/closure/compiler/Runner.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/closure_compiler/README.chromium

diff --git a/third_party/closure_compiler/README.chromium b/third_party/closure_compiler/README.chromium

index e4890439480ebf5bcb5103ffe2ac9d30b7798cdd..fc7701c118c7732517323e2afd8976fa9c2bc531 100644

--- a/third_party/closure_compiler/README.chromium

+++ b/third_party/closure_compiler/README.chromium

@@ -14,9 +14,9 @@ potentially dangerous operations, helping you to produce JavaScript that is less

buggy and easier to maintain.

Local modifications:

-- The compiler is run via a custom mechanism (see: runner/) that sets the

- compiler to "IDE mode" (single-file checks, doesn't stop on first error).

-- Chrome-specific coding conventions to understand cr.addSingletonGetter().

+- A custom runner (see: runner/) to continue on errors, understand and enforce

+ Chrome-specific code, and do checks only (i.e. throw away output). See:

+ --enable-chrome-pass in runner.jar's arguments.

- third_party/closure_compiler/runner/src/com/google/javascript/jscomp/ChromePass.java

Added pass to handle namespace definition with cr.define(), object chain

creation with cr.exportPath(), property definition with