mash: Migrate MediaDelegate ownership and access to WmShell.

mash: Migrate MediaDelegate ownership and access to WmShell.

ash::Shell still calls ShellDelegate::CreateMediaDelegate.

BUG=619636
TEST=Compiles; unit tests; no behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org

Committed: https://crrev.com/2e51cdd0bd22b6309c63a515d667086cec5342c2
Cr-Commit-Position: refs/heads/master@{#403313}

[msw, 2016-06-30 20:10:40]

Hey James, please take a look; thanks!

[msw, 2016-06-30 20:10:45]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-30 20:11:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 20:54:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 20:55:00]

Dry run: This issue passed the CQ dry run.

[James Cook, 2016-06-30 21:19:54]

LGTM. It's so nice to see all these dependencies moving to //ash/common.

https://codereview.chromium.org/2113023002/diff/20001/ash/common/wm_shell.h
File ash/common/wm_shell.h (right):

https://codereview.chromium.org/2113023002/diff/20001/ash/common/wm_shell.h#n...
ash/common/wm_shell.h:191: void
set_media_delegate(std::unique_ptr<MediaDelegate> delegate) {
nit: I would do SetMediaDelegate() and put this in the cc file.

https://codereview.chromium.org/2113023002/diff/20001/ash/common/wm_shell.h#n...
ash/common/wm_shell.h:206: std::unique_ptr<MediaDelegate> media_delegate_;
hooray for keeping them alphabetized!

[msw, 2016-06-30 21:27:55]

Description was changed from

==========
mash: Migrate MediaDelegate ownership and access to WmShell.

ash::Shell still calls ShellDelegate::CreateMediaDelegate.

BUG=619636
TEST=Compiles; unit tests; no behavior changes.
R=jamescook@chromium.org
==========

to

==========
mash: Migrate MediaDelegate ownership and access to WmShell.

ash::Shell still calls ShellDelegate::CreateMediaDelegate.

BUG=619636
TEST=Compiles; unit tests; no behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org
==========

[msw, 2016-06-30 21:27:55]

msw@chromium.org changed reviewers:
+ sky@chromium.org

[msw, 2016-06-30 21:28:18]

+TBR Scott for header path update in chrome/

https://codereview.chromium.org/2113023002/diff/20001/ash/common/wm_shell.h
File ash/common/wm_shell.h (right):

https://codereview.chromium.org/2113023002/diff/20001/ash/common/wm_shell.h#n...
ash/common/wm_shell.h:191: void
set_media_delegate(std::unique_ptr<MediaDelegate> delegate) {
On 2016/06/30 21:19:54, James Cook wrote:
> nit: I would do SetMediaDelegate() and put this in the cc file.

Done.

https://codereview.chromium.org/2113023002/diff/20001/ash/common/wm_shell.h#n...
ash/common/wm_shell.h:206: std::unique_ptr<MediaDelegate> media_delegate_;
On 2016/06/30 21:19:54, James Cook wrote:
> hooray for keeping them alphabetized!

Acknowledged.

[msw, 2016-06-30 21:28:57]

The CQ bit was checked by msw@chromium.org

[msw, 2016-06-30 21:28:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2113023002/#ps40001
(title: "Address comment.")

[commit-bot: I haz the power, 2016-06-30 21:29:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 22:18:43]

Description was changed from

==========
mash: Migrate MediaDelegate ownership and access to WmShell.

ash::Shell still calls ShellDelegate::CreateMediaDelegate.

BUG=619636
TEST=Compiles; unit tests; no behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org
==========

to

==========
mash: Migrate MediaDelegate ownership and access to WmShell.

ash::Shell still calls ShellDelegate::CreateMediaDelegate.

BUG=619636
TEST=Compiles; unit tests; no behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org
==========

[commit-bot: I haz the power, 2016-06-30 22:18:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-30 22:20:22]

Description was changed from

==========
mash: Migrate MediaDelegate ownership and access to WmShell.

ash::Shell still calls ShellDelegate::CreateMediaDelegate.

BUG=619636
TEST=Compiles; unit tests; no behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org
==========

to

==========
mash: Migrate MediaDelegate ownership and access to WmShell.

ash::Shell still calls ShellDelegate::CreateMediaDelegate.

BUG=619636
TEST=Compiles; unit tests; no behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org

Committed: https://crrev.com/2e51cdd0bd22b6309c63a515d667086cec5342c2
Cr-Commit-Position: refs/heads/master@{#403313}
==========

[commit-bot: I haz the power, 2016-06-30 22:20:23]

Patchset 3 (id:??) landed as
https://crrev.com/2e51cdd0bd22b6309c63a515d667086cec5342c2
Cr-Commit-Position: refs/heads/master@{#403313}