Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(824)

Unified Diff: Source/core/editing/SpellChecker.h

Issue 21130005: Trigger spell check/remove markers if spell checker gets enabled/disabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Improvement & test for chunked spell checking. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/editing/SpellChecker.h
diff --git a/Source/core/editing/SpellChecker.h b/Source/core/editing/SpellChecker.h
index 44a6b5a5c84d26b41eb3df6048d516b9fe98d584..17550f0febc85c22ab8a59b5367a2f7c012e6bb2 100644
--- a/Source/core/editing/SpellChecker.h
+++ b/Source/core/editing/SpellChecker.h
@@ -45,7 +45,7 @@ class SpellChecker;
class SpellCheckRequest : public TextCheckingRequest {
public:
- static PassRefPtr<SpellCheckRequest> create(TextCheckingTypeMask, TextCheckingProcessType, PassRefPtr<Range> checkingRange, PassRefPtr<Range> paragraphRange);
+ static PassRefPtr<SpellCheckRequest> create(TextCheckingTypeMask, TextCheckingProcessType, PassRefPtr<Range> checkingRange, PassRefPtr<Range> paragraphRange, int requestNumber = 0);
virtual ~SpellCheckRequest();
PassRefPtr<Range> checkingRange() const { return m_checkingRange; }
@@ -60,14 +60,17 @@ public:
virtual void didSucceed(const Vector<TextCheckingResult>&) OVERRIDE;
virtual void didCancel() OVERRIDE;
+ int requestNumber() { return m_requestNumber; }
please use gerrit instead 2013/08/13 21:54:21 Nit: Please add a "const" keyword after the method
+
private:
- SpellCheckRequest(PassRefPtr<Range> checkingRange, PassRefPtr<Range> paragraphRange, const String&, TextCheckingTypeMask, TextCheckingProcessType, const Vector<uint32_t>& documentMarkersInRange, const Vector<unsigned>& documentMarkerOffsets);
+ SpellCheckRequest(PassRefPtr<Range> checkingRange, PassRefPtr<Range> paragraphRange, const String&, TextCheckingTypeMask, TextCheckingProcessType, const Vector<uint32_t>& documentMarkersInRange, const Vector<unsigned>& documentMarkerOffsets, int requestNo);
please use gerrit instead 2013/08/13 21:54:21 Nit: Please be consistent in naming: s/requestNo/r
SpellChecker* m_checker;
RefPtr<Range> m_checkingRange;
RefPtr<Range> m_paragraphRange;
RefPtr<Element> m_rootEditableElement;
TextCheckingRequestData m_requestData;
+ int m_requestNumber;
};
class SpellChecker {

Powered by Google App Engine
This is Rietveld 408576698