Trigger spell check/remove markers if spell checker gets enabled/disabled.

Source/web/EditorClientImpl.cpp

 /*
  * Copyright (C) 2006, 2007 Apple, Inc.  All rights reserved.
  * Copyright (C) 2012 Google, Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 28 matching lines @@
 #include "WebNode.h"
 #include "WebPermissionClient.h"
 #include "WebRange.h"
 #include "WebSpellCheckClient.h"
 #include "WebTextAffinity.h"
 #include "WebTextCheckingCompletionImpl.h"
 #include "WebTextCheckingResult.h"
 #include "WebViewClient.h"
 #include "WebViewImpl.h"
 #include "core/dom/Document.h"
+#include "core/dom/DocumentMarkerController.h"
 #include "core/dom/EventNames.h"
 #include "core/dom/KeyboardEvent.h"
 #include "core/editing/Editor.h"
 #include "core/editing/SpellChecker.h"
 #include "core/editing/UndoStep.h"
 #include "core/html/HTMLInputElement.h"
 #include "core/page/EventHandler.h"
 #include "core/page/Frame.h"
 #include "core/page/Page.h"
 #include "core/page/Settings.h"
@@ skipping 73 matching lines @@
 {
     if (m_spellCheckThisFieldStatus == SpellCheckForcedOff)
         return false;
     if (m_spellCheckThisFieldStatus == SpellCheckForcedOn)
         return true;
     return shouldSpellcheckByDefault();
 }
 
 void EditorClientImpl::toggleContinuousSpellChecking()
 {
-    if (isContinuousSpellCheckingEnabled())
+    if (isContinuousSpellCheckingEnabled()) {
         m_spellCheckThisFieldStatus = SpellCheckForcedOff;
-    else
+        const Frame* frame = m_webView->focusedWebCoreFrame();
+        if (frame)

[abarth-chromium, 2013/07/31 00:42:14]

No need for "const".  There's no meaningful sense in which Frame can be const.

Also, you can combine this declaration with the if statement.

[pstanek, 2013/08/12 12:21:23]

Won't this remove markers in one frame only (it should do it for the whole
page)? It seems that the main frame from the page should be get here and the
frame tree should be traversed.

+            frame->document()->markers()->removeMarkers(DocumentMarker::Spelling | DocumentMarker::Grammar);
+    } else {
         m_spellCheckThisFieldStatus = SpellCheckForcedOn;
+        const Frame* frame = m_webView->focusedWebCoreFrame();
+        if (frame) {

[abarth-chromium, 2013/07/31 00:42:14]

ditto

+            VisibleSelection frameSelection = frame->selection()->selection();
+            Element* rootEditableElement = frameSelection.rootEditableElement();
+            // If a selection is in an editable element spell check its content.
+            if (rootEditableElement) {

[abarth-chromium, 2013/07/31 00:42:14]

You can also combine this if statement with the previous declaration.

+                VisibleSelection selection = VisibleSelection::selectionFromContentsOfNode(rootEditableElement);
+                frame->editor()->markMisspellingsAndBadGrammar(selection);
+            }
+        }
+    }
 }
 
 bool EditorClientImpl::isGrammarCheckingEnabled()
 {
     const Frame* frame = m_webView->focusedWebCoreFrame();
     return frame && frame->settings() && (frame->settings()->asynchronousSpellCheckingEnabled() || frame->settings()->unifiedTextCheckerEnabled());
 }
 
 bool EditorClientImpl::shouldBeginEditing(Range* range)
 {
@@ skipping 607 matching lines @@
 #endif
 }
 
 void EditorClientImpl::willSetInputMethodState()
 {
     if (m_webView->client())
         m_webView->client()->resetInputMethod();
 }
 
 } // namesace WebKit