Factor draw functionality out of DefaultPlatformDisplay into FrameGenerator.

services/ui/ws/platform_display.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SERVICES_UI_WS_PLATFORM_DISPLAY_H_
 #define SERVICES_UI_WS_PLATFORM_DISPLAY_H_
 
 #include <stdint.h>
 
 #include <map>
 #include <memory>
 
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
 #include "base/strings/string16.h"
-#include "base/timer/timer.h"
 #include "build/build_config.h"
-#include "cc/surfaces/surface.h"
 #include "services/ui/public/interfaces/window_manager.mojom.h"
 #include "services/ui/public/interfaces/window_manager_constants.mojom.h"
 #include "services/ui/public/interfaces/window_tree.mojom.h"
+#include "services/ui/ws/frame_generator.h"
+#include "services/ui/ws/frame_generator_delegate.h"
 #include "services/ui/ws/platform_display_delegate.h"
-#include "services/ui/ws/platform_display_init_params.h"
-#include "ui/gfx/geometry/rect.h"
 #include "ui/platform_window/platform_window_delegate.h"
 
 namespace cc {
-class CompositorFrame;
 class CopyOutputRequest;
-class SurfaceIdAllocator;
-class SurfaceManager;
 }  // namespace cc
 
-namespace gles2 {
-class GpuState;
-}  // namespace gles2
-
-namespace shell {
-class Connector;
-}  // namespace shell
+namespace gfx {
+class Rect;
+}
 
 namespace ui {
 class CursorLoader;
 class PlatformWindow;
 struct TextInputState;
 }  // namespace ui
 
 namespace ui {
 
-class GpuState;
-class SurfacesState;
-class DisplayCompositor;
+class FrameGenerator;
 
 namespace ws {
 
 class EventDispatcher;
 class PlatformDisplayFactory;
+struct PlatformDisplayInitParams;
 class ServerWindow;
 
-struct ViewportMetrics {
-  gfx::Size size_in_pixels;
-  float device_scale_factor = 0.f;
-};
-
 // PlatformDisplay is used to connect the root ServerWindow to a display.
 class PlatformDisplay {
  public:
   virtual ~PlatformDisplay() {}
 
   static PlatformDisplay* Create(const PlatformDisplayInitParams& init_params);
 
   virtual void Init(PlatformDisplayDelegate* delegate) = 0;
 
   // Schedules a paint for the specified region in the coordinates of |window|.
@@ skipping 32 matching lines @@
   }
 
  private:
   // Static factory instance (always NULL for non-test).
   static PlatformDisplayFactory* factory_;
 };
 
 // PlatformDisplay implementation that connects to the services necessary to
 // actually display.
 class DefaultPlatformDisplay : public PlatformDisplay,
-                               public ui::PlatformWindowDelegate {
+                               public ui::PlatformWindowDelegate,
+                               private FrameGeneratorDelegate {
  public:
   explicit DefaultPlatformDisplay(const PlatformDisplayInitParams& init_params);
   ~DefaultPlatformDisplay() override;
 
   // PlatformDisplay:
   void Init(PlatformDisplayDelegate* delegate) override;
   void SchedulePaint(const ServerWindow* window,
                      const gfx::Rect& bounds) override;
   void SetViewportSize(const gfx::Size& size) override;
   void SetTitle(const base::string16& title) override;
   void SetCapture() override;
   void ReleaseCapture() override;
   void SetCursorById(int32_t cursor) override;
   float GetDeviceScaleFactor() override;
   mojom::Rotation GetRotation() override;
   void UpdateTextInputState(const ui::TextInputState& state) override;
   void SetImeVisibility(bool visible) override;
   bool IsFramePending() const override;
   void RequestCopyOfOutput(
       std::unique_ptr<cc::CopyOutputRequest> output_request) override;
   int64_t GetDisplayId() const override;
 
  private:
-  void WantToDraw();
-
-  // This method initiates a top level redraw of the display.
-  // TODO(fsamuel): This should use vblank as a signal rather than a timer
-  // http://crbug.com/533042
-  void Draw();
-
-  // This is called after cc::Display has completed generating a new frame
-  // for the display. TODO(fsamuel): Idle time processing should happen here
-  // if there is budget for it.
-  void DidDraw(cc::SurfaceDrawStatus status);
   void UpdateMetrics(const gfx::Size& size, float device_scale_factor);
-  cc::CompositorFrame GenerateCompositorFrame();
 
   // ui::PlatformWindowDelegate:
   void OnBoundsChanged(const gfx::Rect& new_bounds) override;
   void OnDamageRect(const gfx::Rect& damaged_region) override;
   void DispatchEvent(ui::Event* event) override;
   void OnCloseRequest() override;
   void OnClosed() override;
   void OnWindowStateChanged(ui::PlatformWindowState new_state) override;
   void OnLostCapture() override;
   void OnAcceleratedWidgetAvailable(gfx::AcceleratedWidget widget,
                                     float device_scale_factor) override;
   void OnAcceleratedWidgetDestroyed() override;
   void OnActivationChanged(bool active) override;
 
+  // FrameGeneratorDelegate:
+  ServerWindow* GetRootWindow() override;
+  void OnCompositorFrameDrawn() override;
+  const ViewportMetrics& GetViewportMetrics() override;
+
   int64_t display_id_;
 
-  scoped_refptr<GpuState> gpu_state_;
-  scoped_refptr<SurfacesState> surfaces_state_;
-  PlatformDisplayDelegate* delegate_;
-
-  ViewportMetrics metrics_;
-  gfx::Rect dirty_rect_;
-  base::Timer draw_timer_;
-  bool frame_pending_;
-
-  std::unique_ptr<DisplayCompositor> display_compositor_;
-  std::unique_ptr<ui::PlatformWindow> platform_window_;
-
 #if !defined(OS_ANDROID)
   std::unique_ptr<ui::CursorLoader> cursor_loader_;
 #endif
 
-  base::WeakPtrFactory<DefaultPlatformDisplay> weak_factory_;
+  PlatformDisplayDelegate* delegate_ = nullptr;
+  std::unique_ptr<FrameGenerator> frame_generator_;
+
+  ViewportMetrics metrics_;
+  std::unique_ptr<ui::PlatformWindow> platform_window_;
 
   DISALLOW_COPY_AND_ASSIGN(DefaultPlatformDisplay);
 };
 
 }  // namespace ws
 
 }  // namespace ui
 
 #endif  // SERVICES_UI_WS_PLATFORM_DISPLAY_H_