Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2112973003: cc: Add verify transform tree calculations to LayerTreeSettings (Closed)

Created:
4 years, 5 months ago by jaydasika
Modified:
4 years, 5 months ago
Reviewers:
ajuma, weiliangc
CC:
chromium-reviews, cc-bugs_chromium.org, sunxd
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Add verify transform tree calculations to LayerTreeSettings And also verify draw transform calculations where the destination is not the root. BUG=622372 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/7de66e956615a904bb5d0ada4c61272a9abd33d2 Cr-Commit-Position: refs/heads/master@{#403385}

Patch Set 1 #

Total comments: 1

Patch Set 2 : "TODO" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -2 lines) Patch
M cc/layers/layer_impl_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/picture_layer_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/layer_tree_settings_for_testing.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/layer_tree_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/tiles/tile_manager_unittest.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M cc/trees/draw_property_utils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/trees/draw_property_utils.cc View 1 2 chunks +45 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_common.h View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_common.cc View 4 chunks +6 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_common_perftest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_impl_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_settings.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_settings.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
jaydasika
I started out trying to write something to verify sublayer scale from transform tree and ...
4 years, 5 months ago (2016-06-30 23:41:34 UTC) #3
ajuma
lgtm https://codereview.chromium.org/2112973003/diff/1/cc/trees/draw_property_utils.cc File cc/trees/draw_property_utils.cc (right): https://codereview.chromium.org/2112973003/diff/1/cc/trees/draw_property_utils.cc#newcode906 cc/trees/draw_property_utils.cc:906: if (destination_id == 0 || destination_id == 1) ...
4 years, 5 months ago (2016-06-30 23:59:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112973003/20001
4 years, 5 months ago (2016-07-01 00:33:16 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-01 01:37:11 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-01 01:37:18 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 01:39:18 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7de66e956615a904bb5d0ada4c61272a9abd33d2
Cr-Commit-Position: refs/heads/master@{#403385}

Powered by Google App Engine
This is Rietveld 408576698