Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: runtime/vm/ast.h

Issue 2112973002: Remove invalid assertion in the optimizer (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Mark initializing field stores in the parser Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/ast.h
diff --git a/runtime/vm/ast.h b/runtime/vm/ast.h
index 48b4a225d14b4f342a2998ab2422a700a5a43cab..50c03b1528720aaacafe1631c3fe00f89c0f7777 100644
--- a/runtime/vm/ast.h
+++ b/runtime/vm/ast.h
@@ -1243,11 +1243,13 @@ class StoreInstanceFieldNode : public AstNode {
StoreInstanceFieldNode(TokenPosition token_pos,
AstNode* instance,
const Field& field,
- AstNode* value)
+ AstNode* value,
+ bool is_initializer)
: AstNode(token_pos),
instance_(instance),
field_(*MayCloneField(field)),
- value_(value) {
+ value_(value),
+ is_initializer_(is_initializer) {
ASSERT(instance_ != NULL);
ASSERT(field_.IsZoneHandle());
ASSERT(value_ != NULL);
@@ -1256,6 +1258,7 @@ class StoreInstanceFieldNode : public AstNode {
AstNode* instance() const { return instance_; }
const Field& field() const { return field_; }
AstNode* value() const { return value_; }
+ bool is_initializer() const { return is_initializer_; }
virtual void VisitChildren(AstNodeVisitor* visitor) const {
instance()->Visit(visitor);
@@ -1268,6 +1271,7 @@ class StoreInstanceFieldNode : public AstNode {
AstNode* instance_;
const Field& field_;
AstNode* value_;
+ bool is_initializer_;
Vyacheslav Egorov (Google) 2016/07/01 16:28:23 maybe make this const bool?
Florian Schneider 2016/07/01 16:54:31 Done.
DISALLOW_IMPLICIT_CONSTRUCTORS(StoreInstanceFieldNode);
};
« no previous file with comments | « no previous file | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698