Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 2112943002: SkPDF: Glyph Useage Map improvements (Closed)

Created:
4 years, 5 months ago by hal.canary
Modified:
4 years, 5 months ago
Reviewers:
herb_g
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: Glyph Useage Map improvements Instead of having a fFontGlyphUsage on each device and one on each document, just have the one on the document, and never merge. Make fGlyphUsage accesible on SkPDFDocument. Remove SkPDFGlyphSetMap::merge, ::reset, and SkPDFGlyphSet::merge. SkPDFGlyphSetMap has an TArray of SkPDFGlyphSet, not TDArray of SkPDFGlyphSet pointers. SkPDFGlyphSet and SkPDFBitset get move constructors. All tests produce exactly identical output PDFs. BUG=skia:5434 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2112943002 Committed: https://skia.googlesource.com/skia/+/3c35fb3310c22eb0141c8f39c5423f7bcd42adff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -71 lines) Patch
M src/pdf/SkPDFDevice.h View 4 chunks +1 line, -12 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 8 chunks +8 lines, -16 lines 0 comments Download
M src/pdf/SkPDFDocument.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/pdf/SkPDFDocument.cpp View 5 chunks +4 lines, -2 lines 0 comments Download
M src/pdf/SkPDFFont.h View 3 chunks +10 lines, -9 lines 0 comments Download
M src/pdf/SkPDFFont.cpp View 2 chunks +6 lines, -32 lines 0 comments Download
M src/utils/SkBitSet.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/utils/SkBitSet.cpp View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
hal.canary
PTAL thanks!
4 years, 5 months ago (2016-06-30 18:24:43 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112943002/1
4 years, 5 months ago (2016-06-30 18:26:14 UTC) #6
herb_g
lgtm
4 years, 5 months ago (2016-06-30 18:49:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112943002/1
4 years, 5 months ago (2016-06-30 18:49:33 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 18:55:10 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3c35fb3310c22eb0141c8f39c5423f7bcd42adff

Powered by Google App Engine
This is Rietveld 408576698