content/browser/web_contents/web_contents_impl.h - Issue 2112923002: Fix crash when destroying a RenderWidgetHost that holds the pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 2112923002: Fix crash when destroying a RenderWidgetHost that holds the pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: send privileged request through webcontents Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_widget_host_delegate.h ('K') | « content/browser/renderer_host/render_widget_host_impl.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index ad392c731c1dd6f47bbd0f0bee194edcca4133b8..fa5013db44b16c3a7b0e1e506aa578ee43f8d9b3 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -619,7 +619,8 @@ class CONTENT_EXPORT WebContentsImpl

void RendererResponsive(RenderWidgetHostImpl* render_widget_host) override;

void RequestToLockMouse(RenderWidgetHostImpl* render_widget_host,

bool user_gesture,

- bool last_unlocked_by_target) override;

+ bool last_unlocked_by_target,

+ bool privileged) override;

gfx::Rect GetRootWindowResizerRect(

RenderWidgetHostImpl* render_widget_host) const override;

bool IsFullscreenForCurrentTab() const override;

@@ -627,6 +628,7 @@ class CONTENT_EXPORT WebContentsImpl

RenderWidgetHostImpl* render_widget_host) const override;

void LostCapture(RenderWidgetHostImpl* render_widget_host) override;

void LostMouseLock(RenderWidgetHostImpl* render_widget_host) override;

+ bool HasMouseLock(RenderWidgetHostImpl* render_widget_host) override;

void ForwardCompositorProto(RenderWidgetHostImpl* render_widget_host,

const std::vector<uint8_t>& proto) override;

void OnRenderFrameProxyVisibilityChanged(bool visible) override;