content/browser/frame_host/cross_process_frame_connector.cc - Issue 2112923002: Fix crash when destroying a RenderWidgetHost that holds the pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/cross_process_frame_connector.cc

Issue 2112923002: Fix crash when destroying a RenderWidgetHost that holds the pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: send privileged request through webcontents Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/site_per_process_interactive_browsertest.cc ('K') | « content/browser/frame_host/cross_process_frame_connector.h ('k') | content/browser/frame_host/render_widget_host_view_child_frame.cc » ('j') | content/browser/frame_host/render_widget_host_view_child_frame.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/cross_process_frame_connector.cc

diff --git a/content/browser/frame_host/cross_process_frame_connector.cc b/content/browser/frame_host/cross_process_frame_connector.cc

index 2dd42ddd496727a10c357837480c3f8b74b7a314..1b5dafd2ba41898f8083bb60c4cd5047105a8379 100644

--- a/content/browser/frame_host/cross_process_frame_connector.cc

+++ b/content/browser/frame_host/cross_process_frame_connector.cc

@@ -201,6 +201,12 @@ bool CrossProcessFrameConnector::LockMouse() {

return false;

}

+void CrossProcessFrameConnector::UnlockMouse() {

+ RenderWidgetHostViewBase* root_view = GetRootRenderWidgetHostView();

+ if (root_view)

+ root_view->UnlockMouse();

void CrossProcessFrameConnector::OnForwardInputEvent(

const blink::WebInputEvent* event) {

if (!view_)