Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: content/browser/renderer_host/render_widget_host_delegate.h

Issue 2112923002: Fix crash when destroying a RenderWidgetHost that holds the pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: send privileged request through webcontents Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_DELEGATE_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_DELEGATE_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_DELEGATE_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_DELEGATE_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <vector> 10 #include <vector>
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 // delegate can use this notification to show a warning to the user. 137 // delegate can use this notification to show a warning to the user.
138 virtual void RendererUnresponsive(RenderWidgetHostImpl* render_widget_host) {} 138 virtual void RendererUnresponsive(RenderWidgetHostImpl* render_widget_host) {}
139 139
140 // Notification that a previously unresponsive renderer has become 140 // Notification that a previously unresponsive renderer has become
141 // responsive again. The delegate can use this notification to end the 141 // responsive again. The delegate can use this notification to end the
142 // warning shown to the user. 142 // warning shown to the user.
143 virtual void RendererResponsive(RenderWidgetHostImpl* render_widget_host) {} 143 virtual void RendererResponsive(RenderWidgetHostImpl* render_widget_host) {}
144 144
145 // Requests to lock the mouse. Once the request is approved or rejected, 145 // Requests to lock the mouse. Once the request is approved or rejected,
146 // GotResponseToLockMouseRequest() will be called on the requesting render 146 // GotResponseToLockMouseRequest() will be called on the requesting render
147 // widget host. 147 // widget host.
Charlie Reis 2016/07/07 21:47:13 Can you mention what privileged means?
lfg 2016/07/11 19:11:29 Done.
148 virtual void RequestToLockMouse(RenderWidgetHostImpl* render_widget_host, 148 virtual void RequestToLockMouse(RenderWidgetHostImpl* render_widget_host,
149 bool user_gesture, 149 bool user_gesture,
150 bool last_unlocked_by_target) {} 150 bool last_unlocked_by_target,
151 bool privileged) {}
151 152
152 // Return the rect where to display the resize corner, if any, otherwise 153 // Return the rect where to display the resize corner, if any, otherwise
153 // an empty rect. 154 // an empty rect.
154 virtual gfx::Rect GetRootWindowResizerRect( 155 virtual gfx::Rect GetRootWindowResizerRect(
155 RenderWidgetHostImpl* render_widget_host) const; 156 RenderWidgetHostImpl* render_widget_host) const;
156 157
157 // Returns whether the associated tab is in fullscreen mode. 158 // Returns whether the associated tab is in fullscreen mode.
158 virtual bool IsFullscreenForCurrentTab() const; 159 virtual bool IsFullscreenForCurrentTab() const;
159 160
160 // Returns the display mode for the view. 161 // Returns the display mode for the view.
161 virtual blink::WebDisplayMode GetDisplayMode( 162 virtual blink::WebDisplayMode GetDisplayMode(
162 RenderWidgetHostImpl* render_widget_host) const; 163 RenderWidgetHostImpl* render_widget_host) const;
163 164
164 // Notification that the widget has lost capture. 165 // Notification that the widget has lost capture.
165 virtual void LostCapture(RenderWidgetHostImpl* render_widget_host) {} 166 virtual void LostCapture(RenderWidgetHostImpl* render_widget_host) {}
166 167
167 // Notification that the widget has lost the mouse lock. 168 // Notification that the widget has lost the mouse lock.
168 virtual void LostMouseLock(RenderWidgetHostImpl* render_widget_host) {} 169 virtual void LostMouseLock(RenderWidgetHostImpl* render_widget_host) {}
169 170
171 // Returns true if |render_widget_host| holds the mouse lock.
172 virtual bool HasMouseLock(RenderWidgetHostImpl* render_widget_host);
173
170 // Called when the widget has sent a compositor proto. This is used in Btlimp 174 // Called when the widget has sent a compositor proto. This is used in Btlimp
171 // mode with the RemoteChannel compositor. 175 // mode with the RemoteChannel compositor.
172 virtual void ForwardCompositorProto(RenderWidgetHostImpl* render_widget_host, 176 virtual void ForwardCompositorProto(RenderWidgetHostImpl* render_widget_host,
173 const std::vector<uint8_t>& proto) {} 177 const std::vector<uint8_t>& proto) {}
174 178
175 // Called when the visibility of the RenderFrameProxyHost in outter 179 // Called when the visibility of the RenderFrameProxyHost in outter
176 // WebContents changes. This method is only called on an inner WebContents and 180 // WebContents changes. This method is only called on an inner WebContents and
177 // will eventually notify all the RenderWidgetHostViews belonging to that 181 // will eventually notify all the RenderWidgetHostViews belonging to that
178 // WebContents. 182 // WebContents.
179 virtual void OnRenderFrameProxyVisibilityChanged(bool visible) {} 183 virtual void OnRenderFrameProxyVisibilityChanged(bool visible) {}
180 184
181 // Update the renderer's cache of the screen rect of the view and window. 185 // Update the renderer's cache of the screen rect of the view and window.
182 virtual void SendScreenRects() {} 186 virtual void SendScreenRects() {}
183 187
184 // Notifies that the main frame in the renderer has performed the first paint 188 // Notifies that the main frame in the renderer has performed the first paint
185 // after a navigation. 189 // after a navigation.
186 virtual void OnFirstPaintAfterLoad(RenderWidgetHostImpl* render_widget_host) { 190 virtual void OnFirstPaintAfterLoad(RenderWidgetHostImpl* render_widget_host) {
187 } 191 }
188 192
189 // Returns the TextInputManager tracking text input state. 193 // Returns the TextInputManager tracking text input state.
190 virtual TextInputManager* GetTextInputManager(); 194 virtual TextInputManager* GetTextInputManager();
191 195
192 protected: 196 protected:
193 virtual ~RenderWidgetHostDelegate() {} 197 virtual ~RenderWidgetHostDelegate() {}
194 }; 198 };
195 199
196 } // namespace content 200 } // namespace content
197 201
198 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_DELEGATE_H_ 202 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698