Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

Issue 2112923002: Fix crash when destroying a RenderWidgetHost that holds the pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/render_widget_host_view_aura.h" 5 #include "content/browser/renderer_host/render_widget_host_view_aura.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <tuple> 10 #include <tuple>
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 // RenderWidgetHostDelegate: 173 // RenderWidgetHostDelegate:
174 bool PreHandleKeyboardEvent(const NativeWebKeyboardEvent& event, 174 bool PreHandleKeyboardEvent(const NativeWebKeyboardEvent& event,
175 bool* is_keyboard_shortcut) override { 175 bool* is_keyboard_shortcut) override {
176 last_event_.reset(new NativeWebKeyboardEvent(event)); 176 last_event_.reset(new NativeWebKeyboardEvent(event));
177 return true; 177 return true;
178 } 178 }
179 void Cut() override {} 179 void Cut() override {}
180 void Copy() override {} 180 void Copy() override {}
181 void Paste() override {} 181 void Paste() override {}
182 void SelectAll() override {} 182 void SelectAll() override {}
183 bool HasMouseLock(RenderWidgetHostImpl*) override { return false; }
183 void SendScreenRects() override { 184 void SendScreenRects() override {
184 if (rwh_) 185 if (rwh_)
185 rwh_->SendScreenRects(); 186 rwh_->SendScreenRects();
186 } 187 }
187 bool IsFullscreenForCurrentTab() const override { return is_fullscreen_; } 188 bool IsFullscreenForCurrentTab() const override { return is_fullscreen_; }
188 189
189 private: 190 private:
190 std::unique_ptr<NativeWebKeyboardEvent> last_event_; 191 std::unique_ptr<NativeWebKeyboardEvent> last_event_;
191 RenderWidgetHostImpl* rwh_; 192 RenderWidgetHostImpl* rwh_;
192 bool is_fullscreen_; 193 bool is_fullscreen_;
(...skipping 4017 matching lines...) Expand 10 before | Expand all | Expand 10 after
4210 base::Bind(&ui::TextInputClient::InsertText, 4211 base::Bind(&ui::TextInputClient::InsertText,
4211 base::Unretained(text_input_client()), base::string16()); 4212 base::Unretained(text_input_client()), base::string16());
4212 for (auto index : active_view_sequence_) { 4213 for (auto index : active_view_sequence_) {
4213 ActivateViewForTextInputManager(views_[index], ui::TEXT_INPUT_TYPE_TEXT); 4214 ActivateViewForTextInputManager(views_[index], ui::TEXT_INPUT_TYPE_TEXT);
4214 EXPECT_TRUE(!!RunAndReturnIPCSent(ime_call, processes_[index], 4215 EXPECT_TRUE(!!RunAndReturnIPCSent(ime_call, processes_[index],
4215 InputMsg_ImeConfirmComposition::ID)); 4216 InputMsg_ImeConfirmComposition::ID));
4216 } 4217 }
4217 } 4218 }
4218 4219
4219 } // namespace content 4220 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698