Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: content/browser/frame_host/interstitial_page_impl.cc

Issue 2112923002: Fix crash when destroying a RenderWidgetHost that holds the pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/interstitial_page_impl.h" 5 #include "content/browser/frame_host/interstitial_page_impl.h"
6 6
7 #include <utility> 7 #include <utility>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 447 matching lines...) Expand 10 before | Expand all | Expand 10 after
458 void InterstitialPageImpl::SelectAll() { 458 void InterstitialPageImpl::SelectAll() {
459 FrameTreeNode* focused_node = frame_tree_.GetFocusedFrame(); 459 FrameTreeNode* focused_node = frame_tree_.GetFocusedFrame();
460 if (!focused_node) 460 if (!focused_node)
461 return; 461 return;
462 462
463 focused_node->current_frame_host()->Send(new InputMsg_SelectAll( 463 focused_node->current_frame_host()->Send(new InputMsg_SelectAll(
464 focused_node->current_frame_host()->GetRoutingID())); 464 focused_node->current_frame_host()->GetRoutingID()));
465 RecordAction(base::UserMetricsAction("SelectAll")); 465 RecordAction(base::UserMetricsAction("SelectAll"));
466 } 466 }
467 467
468 bool InterstitialPageImpl::HasMouseLock(
469 RenderWidgetHostImpl* render_widget_host) {
470 return false;
471 }
472
468 RenderViewHostDelegateView* InterstitialPageImpl::GetDelegateView() { 473 RenderViewHostDelegateView* InterstitialPageImpl::GetDelegateView() {
469 return rvh_delegate_view_.get(); 474 return rvh_delegate_view_.get();
470 } 475 }
471 476
472 WebContents* InterstitialPageImpl::GetWebContents() const { 477 WebContents* InterstitialPageImpl::GetWebContents() const {
473 return web_contents(); 478 return web_contents();
474 } 479 }
475 480
476 const GURL& InterstitialPageImpl::GetMainFrameLastCommittedURL() const { 481 const GURL& InterstitialPageImpl::GetMainFrameLastCommittedURL() const {
477 return url_; 482 return url_;
(...skipping 462 matching lines...) Expand 10 before | Expand all | Expand 10 after
940 void InterstitialPageImpl::UnderlyingContentObserver::WebContentsDestroyed() { 945 void InterstitialPageImpl::UnderlyingContentObserver::WebContentsDestroyed() {
941 interstitial_->OnNavigatingAwayOrTabClosing(); 946 interstitial_->OnNavigatingAwayOrTabClosing();
942 } 947 }
943 948
944 TextInputManager* InterstitialPageImpl::GetTextInputManager() { 949 TextInputManager* InterstitialPageImpl::GetTextInputManager() {
945 return !web_contents_ ? nullptr : static_cast<WebContentsImpl*>(web_contents_) 950 return !web_contents_ ? nullptr : static_cast<WebContentsImpl*>(web_contents_)
946 ->GetTextInputManager(); 951 ->GetTextInputManager();
947 } 952 }
948 953
949 } // namespace content 954 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698