Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 2112913002: [net] Fix initializer list for static MockTransaction definitions. (Closed)

Created:
4 years, 5 months ago by asanka
Modified:
4 years, 5 months ago
Reviewers:
mmenke
CC:
cbentzel+watch_chromium.org, chromium-reviews, gavinp+disk_chromium.org, kinuko+cache_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[net] Fix initializer list for static MockTransaction definitions. Change b5fb4b4394a9c60ee711ee9f434072a7e7aee513 introduced a new field to `struct net::MockTransaction`, however there were few more MockTransaction initializations that were not updated in that commit. R=mmenke@chromium.org BUG=none Committed: https://crrev.com/7eb4a0914da71ac5436fa7b7c9d689b9f62579de Cr-Commit-Position: refs/heads/master@{#403219}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : @ #

Patch Set 4 : @ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -28 lines) Patch
M net/http/disk_cache_based_quic_server_info_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M net/url_request/url_request_job_unittest.cc View 5 chunks +10 lines, -28 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
asanka
4 years, 5 months ago (2016-06-30 17:43:21 UTC) #3
mmenke
LGTM. Aren't enums and pointers lovely? :(
4 years, 5 months ago (2016-06-30 17:47:52 UTC) #4
asanka
On 2016/06/30 at 17:47:52, mmenke wrote: > LGTM. Aren't enums and pointers lovely? :( They're ...
4 years, 5 months ago (2016-06-30 17:53:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112913002/60001
4 years, 5 months ago (2016-06-30 17:53:43 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-06-30 18:00:26 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 18:00:28 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 18:02:13 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/7eb4a0914da71ac5436fa7b7c9d689b9f62579de
Cr-Commit-Position: refs/heads/master@{#403219}

Powered by Google App Engine
This is Rietveld 408576698