Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 2112893002: Use unordered map hash on ConstructedConstantValue. (Closed)

Created:
4 years, 5 months ago by Johnni Winther
Modified:
4 years, 5 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use unordered map hash on ConstructedConstantValue. R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/a8114631c78bb7b8573019a46d51a291b440655a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -1 line) Patch
M pkg/compiler/lib/src/constants/values.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/util/util.dart View 1 chunk +10 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/constant_value_test.dart View 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years, 5 months ago (2016-06-30 14:07:01 UTC) #2
Harry Terkelsen
lgtm
4 years, 5 months ago (2016-06-30 17:26:03 UTC) #3
Johnni Winther
4 years, 5 months ago (2016-07-01 10:46:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a8114631c78bb7b8573019a46d51a291b440655a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698