Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2112883002: [builtins] Fix MathMaxMin on arm and arm64 (Closed)

Created:
4 years, 5 months ago by jgruber
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Fix MathMaxMin on arm and arm64 Both of these were broken in different ways: * On arm, the loop counter was passed as argc on the stack. * On arm64, we passed argc + 1 instead of argc. The result in both cases was an incorrect receiver for the builtin frame when generating stack traces. BUG=v8:4815 R=bmeurer@chromium.org Committed: https://crrev.com/b86ac0e05a1e4a34944bdc3c0c6702945387b431 Cr-Commit-Position: refs/heads/master@{#37471}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -24 lines) Patch
M src/arm/builtins-arm.cc View 3 chunks +12 lines, -12 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 3 chunks +12 lines, -12 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112883002/1
4 years, 5 months ago (2016-06-30 13:27:34 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-30 13:52:11 UTC) #4
jgruber
Tests for this are in https://codereview.chromium.org/2110683007/
4 years, 5 months ago (2016-06-30 14:14:11 UTC) #5
Benedikt Meurer
Thanks, LGTM!
4 years, 5 months ago (2016-07-01 03:45:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112883002/1
4 years, 5 months ago (2016-07-01 06:58:10 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 07:00:14 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 07:02:48 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b86ac0e05a1e4a34944bdc3c0c6702945387b431
Cr-Commit-Position: refs/heads/master@{#37471}

Powered by Google App Engine
This is Rietveld 408576698