Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 211283005: Revert of Handle Search suggest subtypes for Shortcuts DB (Closed)

Created:
6 years, 9 months ago by erikchen
Modified:
6 years, 9 months ago
Reviewers:
Anuj, Peter Kasting
CC:
chromium-reviews, browser-components-watch_chromium.org
Visibility:
Public.

Description

Revert of Handle Search suggest subtypes for Shortcuts DB (https://codereview.chromium.org/165163002/) Reason for revert: http://build.chromium.org/p/chromium.win/builders/Interactive%20Tests%20%28dbg%29/builds/46817/steps/interactive_ui_tests/logs/stdio Original issue's description: > Handle SEARCH_SUGGEST_.+ types for Shortcuts DB > > - I think fill_into_edit should work just fine for Search Suggest types. > > BUG=341137 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259206 TBR=pkasting@chromium.org,skanuj@chromium.org NOTREECHECKS=true NOTRY=true BUG=341137 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259251

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -147 lines) Patch
M chrome/browser/autocomplete/autocomplete_match.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_match.cc View 1 chunk +3 lines, -8 lines 0 comments Download
M chrome/browser/autocomplete/base_search_provider.h View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/autocomplete/base_search_provider.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/browser/autocomplete/shortcuts_backend.h View 3 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/autocomplete/shortcuts_backend.cc View 5 chunks +17 lines, -29 lines 0 comments Download
M chrome/browser/autocomplete/shortcuts_backend_unittest.cc View 7 chunks +14 lines, -79 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
erikchen
Created Revert of Handle Search suggest subtypes for Shortcuts DB
6 years, 9 months ago (2014-03-25 17:50:18 UTC) #1
erikchen
stevenjb reproduced the test failure locally on his machine. this CL was responsible.
6 years, 9 months ago (2014-03-25 17:51:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/211283005/1
6 years, 9 months ago (2014-03-25 17:51:13 UTC) #3
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 17:52:58 UTC) #4
Message was sent while issue was closed.
Change committed as 259251

Powered by Google App Engine
This is Rietveld 408576698